Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: chrome/browser/autocomplete/history_provider.cc

Issue 229733004: Omnibox: Make Bookmarks Set Inline_Autocompletion (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: massive new patch, new change description Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/history_provider.cc
diff --git a/chrome/browser/autocomplete/history_provider.cc b/chrome/browser/autocomplete/history_provider.cc
index 989ae388f614411f73831341a2cc0b80d20bb93e..665f80b81df66f095a5b2e7df4460eed402bf56a 100644
--- a/chrome/browser/autocomplete/history_provider.cc
+++ b/chrome/browser/autocomplete/history_provider.cc
@@ -18,12 +18,6 @@
#include "chrome/common/url_constants.h"
#include "url/url_util.h"
-HistoryProvider::HistoryProvider(AutocompleteProviderListener* listener,
Mark P 2014/04/09 22:03:17 This moved below for better consistency with decla
- Profile* profile,
- AutocompleteProvider::Type type)
- : AutocompleteProvider(listener, profile, type) {
-}
-
void HistoryProvider::DeleteMatch(const AutocompleteMatch& match) {
DCHECK(done_);
DCHECK(profile_);
@@ -39,6 +33,20 @@ void HistoryProvider::DeleteMatch(const AutocompleteMatch& match) {
DeleteMatchFromMatches(match);
}
+// static
Mark P 2014/04/09 22:03:17 This was moved from below with no changes.
+bool HistoryProvider::PreventInlineAutocomplete(
+ const AutocompleteInput& input) {
+ return input.prevent_inline_autocomplete() ||
+ (!input.text().empty() &&
+ IsWhitespace(input.text()[input.text().length() - 1]));
+}
+
+HistoryProvider::HistoryProvider(AutocompleteProviderListener* listener,
+ Profile* profile,
+ AutocompleteProvider::Type type)
+ : AutocompleteProvider(listener, profile, type) {
+}
+
HistoryProvider::~HistoryProvider() {}
void HistoryProvider::DeleteMatchFromMatches(const AutocompleteMatch& match) {
@@ -62,14 +70,6 @@ void HistoryProvider::DeleteMatchFromMatches(const AutocompleteMatch& match) {
}
// static
-bool HistoryProvider::PreventInlineAutocomplete(
- const AutocompleteInput& input) {
- return input.prevent_inline_autocomplete() ||
- (!input.text().empty() &&
- IsWhitespace(input.text()[input.text().length() - 1]));
-}
-
-// static
ACMatchClassifications HistoryProvider::SpansFromTermMatch(
const history::TermMatches& matches,
size_t text_length,

Powered by Google App Engine
This is Rietveld 408576698