Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: chrome/browser/autocomplete/bookmark_provider.h

Issue 229733004: Omnibox: Make Bookmarks Set Inline_Autocompletion (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Peter's comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/bookmark_provider.h
diff --git a/chrome/browser/autocomplete/bookmark_provider.h b/chrome/browser/autocomplete/bookmark_provider.h
index ecd7b705c3c01fcfbe7fc930cc2c21ac13e6b1f2..5ddfaa385391dff1f18bce2cbb1b1c1dfd79727c 100644
--- a/chrome/browser/autocomplete/bookmark_provider.h
+++ b/chrome/browser/autocomplete/bookmark_provider.h
@@ -40,6 +40,8 @@ class BookmarkProvider : public AutocompleteProvider {
}
private:
+ FRIEND_TEST_ALL_PREFIXES(BookmarkProviderTest, InlineAutocompletion);
+
virtual ~BookmarkProvider();
// Performs the actual matching of |input| over the bookmarks and fills in
@@ -49,8 +51,13 @@ class BookmarkProvider : public AutocompleteProvider {
// Compose an AutocompleteMatch based on |title_match| that has 1) the URL of
// title_match's bookmark, and 2) the bookmark's title, not the URL's page
- // title, as the description.
- AutocompleteMatch TitleMatchToACMatch(const BookmarkTitleMatch& title_match);
+ // title, as the description. |input| is used to compute the match's
+ // inline_autocompletion. |fixed_up_input| is used in that way as well;
+ // it's passed separately so this function doesn't have to compute it.
+ AutocompleteMatch TitleMatchToACMatch(
+ const AutocompleteInput& input,
+ const AutocompleteInput& fixed_up_input,
+ const BookmarkTitleMatch& title_match);
// Converts |positions| into ACMatchClassifications and returns the
// classifications. |text_length| is used to determine the need to add an
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_provider.h ('k') | chrome/browser/autocomplete/bookmark_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698