Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: chrome/browser/autocomplete/autocomplete_provider.h

Issue 229733004: Omnibox: Make Bookmarks Set Inline_Autocompletion (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: expand shortcuts test Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_PROVIDER_H_
6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_PROVIDER_H_ 6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_PROVIDER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 } 232 }
233 #endif 233 #endif
234 // A suggested upper bound for how many matches a provider should return. 234 // A suggested upper bound for how many matches a provider should return.
235 // TODO(pkasting): http://b/1111299 , http://b/933133 This should go away once 235 // TODO(pkasting): http://b/1111299 , http://b/933133 This should go away once
236 // we have good relevance heuristics; the controller should handle all 236 // we have good relevance heuristics; the controller should handle all
237 // culling. 237 // culling.
238 static const size_t kMaxMatches; 238 static const size_t kMaxMatches;
239 239
240 protected: 240 protected:
241 friend class base::RefCountedThreadSafe<AutocompleteProvider>; 241 friend class base::RefCountedThreadSafe<AutocompleteProvider>;
242 FRIEND_TEST_ALL_PREFIXES(BookmarkProviderTest, InlineAutocompletion);
242 243
243 virtual ~AutocompleteProvider(); 244 virtual ~AutocompleteProvider();
244 245
245 // Updates the starred state of each of the matches in matches_ from the 246 // Updates the starred state of each of the matches in matches_ from the
246 // profile's bookmark bar model. 247 // profile's bookmark bar model.
247 void UpdateStarredStateOfMatches(); 248 void UpdateStarredStateOfMatches();
248 249
249 // Fixes up user URL input to make it more possible to match against. Among 250 // Fixes up user URL input to make it more possible to match against. Among
250 // many other things, this takes care of the following: 251 // many other things, this takes care of the following:
251 // * Prepending file:// to file URLs 252 // * Prepending file:// to file URLs
(...skipping 24 matching lines...) Expand all
276 277
277 Type type_; 278 Type type_;
278 279
279 private: 280 private:
280 DISALLOW_COPY_AND_ASSIGN(AutocompleteProvider); 281 DISALLOW_COPY_AND_ASSIGN(AutocompleteProvider);
281 }; 282 };
282 283
283 typedef std::vector<AutocompleteProvider*> ACProviders; 284 typedef std::vector<AutocompleteProvider*> ACProviders;
284 285
285 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_PROVIDER_H_ 286 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_PROVIDER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/autocomplete/bookmark_provider.h » ('j') | chrome/browser/autocomplete/bookmark_provider.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698