apps/shell/DEPS - Issue 229733002: Toro: Move ExtensionProtocolHandler to //extensions

Side by Side Diff: apps/shell/DEPS

Issue 229733002: Toro: Move ExtensionProtocolHandler to //extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: move file, cleanup (extension-protocols) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | apps/shell/browser/shell_content_browser_client.cc » ('j') | apps/shell/browser/shell_content_browser_client.cc » ('J')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # The apps module has dependencies on chrome.	2 # The apps module has dependencies on chrome.

3 "-apps",	3 "-apps",

4 # Individual subdirectories should have their own DEPS that include	4 # Individual subdirectories should have their own DEPS that include

5 # their allowed directories.	5 # their allowed directories.

6 "-apps/shell",	6 "-apps/shell",

7 "+apps/shell/common",	7 "+apps/shell/common",

8 "+apps/shell/test",	8 "+apps/shell/test",

9	9

10 # Real DEPS go in subdirectories, for example apps/shell/browser/DEPS.	10 # Real DEPS go in subdirectories, for example apps/shell/browser/DEPS.

11 # Temporary exceptions for app_shell bring-up go here.	11 # Temporary exceptions for app_shell bring-up go here.

12 # TODO(jamescook): Remove these. http://crbug.com/305404	12 # TODO(jamescook): Remove these. http://crbug.com/305404

13 "!chrome/browser/extensions/extension_protocols.h",	13 "!chrome/browser/chrome_notification_types.h",
	James Cook 2014/04/09 22:54:41 I did not add any includes of this file, but I not I did not add any includes of this file, but I noticed it was being picked up from apps/DEPS. (I tried adding -chrome to apps/shell/browser/DEPS and discovered it.) I think we should set noparent on this DEPS file but I'd like to do that in another CL. Yoyo Zhou 2014/04/10 21:10:49 Can you actually set noparent on DEPS? If we can, Show quoted text On 2014/04/09 22:54:41, James Cook wrote: > I did not add any includes of this file, but I noticed it was being picked up > from apps/DEPS. (I tried adding -chrome to apps/shell/browser/DEPS and > discovered it.) > > I think we should set noparent on this DEPS file but I'd like to do that in > another CL. Can you actually set noparent on DEPS? If we can, then yes. James Cook 2014/04/10 21:32:05 It turns out you can't do noparent on DEPS, only o Show quoted text On 2014/04/10 21:10:49, Yoyo Zhou wrote: > On 2014/04/09 22:54:41, James Cook wrote: > > I did not add any includes of this file, but I noticed it was being picked up > > from apps/DEPS. (I tried adding -chrome to apps/shell/browser/DEPS and > > discovered it.) > > > > I think we should set noparent on this DEPS file but I'd like to do that in > > another CL. > > Can you actually set noparent on DEPS? If we can, then yes. It turns out you can't do noparent on DEPS, only on OWNERS. However, I can add -chrome.
14 "!chrome/browser/extensions/extension_resource_protocols.h",

15 "!chrome/common/extensions/api/generated_api.h",	14 "!chrome/common/extensions/api/generated_api.h",

16 "!chrome/common/extensions/api/generated_schemas.h",	15 "!chrome/common/extensions/api/generated_schemas.h",

17 "!chrome/common/extensions/api/sockets/sockets_manifest_handler.h",	16 "!chrome/common/extensions/api/sockets/sockets_manifest_handler.h",

18 "!chrome/common/extensions/extension_file_util.h",	17 "!chrome/common/extensions/extension_file_util.h",

19 "!chrome/common/extensions/features/base_feature_provider.h",	18 "!chrome/common/extensions/features/base_feature_provider.h",

20 "!chrome/common/extensions/features/base_feature_provider.h",	19 "!chrome/common/extensions/features/base_feature_provider.h",

21 "!chrome/common/extensions/permissions/chrome_api_permissions.h",	20 "!chrome/common/extensions/permissions/chrome_api_permissions.h",

22 "!chrome/renderer/extensions/dispatcher.h",	21 "!chrome/renderer/extensions/dispatcher.h",

23 "!chrome/renderer/extensions/extension_helper.h",	22 "!chrome/renderer/extensions/extension_helper.h",

24 ]	23 ]

OLD	NEW