Toro: Move ExtensionProtocolHandler to //extensions

Toro: Move ExtensionProtocolHandler to //extensions

This breaks Chrome dependencies in ExtensionProtocolHandler and moves //chrome/browser/extensions/extension_protocol.cc into //extensions/browser so it can be used in app_shell.

* Extract URLRequestResourceBundleJob to Chrome as it is used only to load component extension resources from Chrome's PAK files.
* Replace Profile::ProfileType usage with is_incognito to break the Profile dependency.
* Delegate out the decision to allow cross-renderer extension resource loads because this is primarily used for Chrome-specific extension features
* Eliminate chrome-extension-resource:// handling in app_shell (it allows sharing common extension data in the <chrome-install>/resources/extension/ directory, which app_shell doesn't need).

BUG=361373
TEST=browser_tests *Extension* and PlatformApp*, unit_tests ExtensionProtocol*, app_shell loads calculator
TBR=sky@chromium.org for mechanical header file move/refactor across chrome/browser

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263198

[James Cook, 2014-04-09 22:54:41]

yoz, PTAL

https://codereview.chromium.org/229733002/diff/120001/apps/shell/DEPS
File apps/shell/DEPS (right):

https://codereview.chromium.org/229733002/diff/120001/apps/shell/DEPS#newcode13
apps/shell/DEPS:13: "!chrome/browser/chrome_notification_types.h",
I did not add any includes of this file, but I noticed it was being picked up
from apps/DEPS.  (I tried adding -chrome to apps/shell/browser/DEPS and
discovered it.)

I think we should set noparent on this DEPS file but I'd like to do that in
another CL.

https://codereview.chromium.org/229733002/diff/120001/apps/shell/browser/shel...
File apps/shell/browser/shell_content_browser_client.cc (right):

https://codereview.chromium.org/229733002/diff/120001/apps/shell/browser/shel...
apps/shell/browser/shell_content_browser_client.cc:83: // data in its
installation directory).
We don't need chrome-extension-resource. It was developed to do things like
store Google Analytics JS in the Chrome <install>/resources/extensions
directory.

It's unclear if this feature is still used by Chrome extensions (there are a few
references to it for extensions in the web store) but app_shell doesn't need it.

https://codereview.chromium.org/229733002/diff/120001/chrome/browser/extensio...
File chrome/browser/extensions/url_request_util.cc (right):

https://codereview.chromium.org/229733002/diff/120001/chrome/browser/extensio...
chrome/browser/extensions/url_request_util.cc:43: class
URLRequestResourceBundleJob : public net::URLRequestSimpleJob {
This is moved unchanged from extension_protocols.cc

https://codereview.chromium.org/229733002/diff/120001/chrome/browser/extensio...
chrome/browser/extensions/url_request_util.cc:139: 
From here down is unchanged from extension_protocols.cc, modulo
formatting/namespaces.

https://codereview.chromium.org/229733002/diff/120001/chrome/browser/extensio...
chrome/browser/extensions/url_request_util.cc:201: if
(!ManifestURL::GetDevToolsPage(extension).is_empty())
This conditional is reversed from the original code to allow "return false" to
be the default.

https://codereview.chromium.org/229733002/diff/120001/extensions/browser/exte...
File extensions/browser/extension_protocols.cc (right):

https://codereview.chromium.org/229733002/diff/120001/extensions/browser/exte...
extensions/browser/extension_protocols.cc:444: net::HttpResponseHeaders*
BuildHttpHeaders(
Moved unchanged from above to let the Chrome code share it.

[Yoyo Zhou, 2014-04-10 21:10:49]

LGTM

https://chromiumcodereview.appspot.com/229733002/diff/120001/apps/shell/DEPS
File apps/shell/DEPS (right):

https://chromiumcodereview.appspot.com/229733002/diff/120001/apps/shell/DEPS#...
apps/shell/DEPS:13: "!chrome/browser/chrome_notification_types.h",
On 2014/04/09 22:54:41, James Cook wrote:
> I did not add any includes of this file, but I noticed it was being picked up
> from apps/DEPS.  (I tried adding -chrome to apps/shell/browser/DEPS and
> discovered it.)
> 
> I think we should set noparent on this DEPS file but I'd like to do that in
> another CL.

Can you actually set noparent on DEPS? If we can, then yes.

[James Cook, 2014-04-10 21:32:04]

https://chromiumcodereview.appspot.com/229733002/diff/120001/apps/shell/DEPS
File apps/shell/DEPS (right):

https://chromiumcodereview.appspot.com/229733002/diff/120001/apps/shell/DEPS#...
apps/shell/DEPS:13: "!chrome/browser/chrome_notification_types.h",
On 2014/04/10 21:10:49, Yoyo Zhou wrote:
> On 2014/04/09 22:54:41, James Cook wrote:
> > I did not add any includes of this file, but I noticed it was being picked
up
> > from apps/DEPS.  (I tried adding -chrome to apps/shell/browser/DEPS and
> > discovered it.)
> > 
> > I think we should set noparent on this DEPS file but I'd like to do that in
> > another CL.
> 
> Can you actually set noparent on DEPS? If we can, then yes.

It turns out you can't do noparent on DEPS, only on OWNERS.  However, I can add
-chrome.

[James Cook, 2014-04-10 21:55:21]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-04-10 21:56:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/229733002/160001

[commit-bot: I haz the power, 2014-04-11 02:18:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-11 02:18:59]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Yoyo Zhou, 2014-04-11 05:53:13]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-04-11 05:54:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/229733002/160001

[commit-bot: I haz the power, 2014-04-11 08:29:15]

Change committed as 263198