xfa/fgas/font/fgas_stdfontmgr.cpp - Issue 2297303004: Fix leaked internal font

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fgas/font/fgas_stdfontmgr.cpp

Issue 2297303004: Fix leaked internal font (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fgas/font/fgas_stdfontmgr.cpp

diff --git a/xfa/fgas/font/fgas_stdfontmgr.cpp b/xfa/fgas/font/fgas_stdfontmgr.cpp

index 7e5cfbb796541347843c2a775739733963f7db1d..d9f3360c46535f02d658f6108f876211115986b9 100644

--- a/xfa/fgas/font/fgas_stdfontmgr.cpp

+++ b/xfa/fgas/font/fgas_stdfontmgr.cpp

@@ -856,7 +856,7 @@ CFGAS_GEFont* CFGAS_FontMgrImp::LoadFont(const CFX_WideString& wsFaceName,

return nullptr;

}

- CFGAS_GEFont* pFont = CFGAS_GEFont::LoadFont(pInternalFont, this);

+ CFGAS_GEFont* pFont = CFGAS_GEFont::LoadFont(pInternalFont, false, this);

if (!pFont) {

pFontStream->Release();

return nullptr;