Fix leaked internal font

Fix leaked internal font

In CFGAS_FontMgrImp::LoadFont(), a new internal font is created which
is never released. It needs to be correctly marked as internal font to
be released. Fix this by adding a boolean parameter and pass it along
during the creation of the font.

BUG=pdfium:242
Committed: https://pdfium.googlesource.com/pdfium/+/6708106e6a3d54f3370c871ebf6643d1ecf58999

[Wei Li, 2016-09-01 22:22:46]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 22:22:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 22:34:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 22:34:34]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-09-01 22:44:46]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Wei Li, 2016-09-01 22:44:46]

pls review, thanks

[Lei Zhang, 2016-09-01 22:55:42]

lgtm with some suggestions.

https://codereview.chromium.org/2297303004/diff/1/xfa/fgas/font/fgas_gefont.cpp
File xfa/fgas/font/fgas_gefont.cpp (right):

https://codereview.chromium.org/2297303004/diff/1/xfa/fgas/font/fgas_gefont.c...
xfa/fgas/font/fgas_gefont.cpp:218: m_bExtFont = bExternalFont;
Can we name |m_bExtFont| to |m_bExternalFont| later? "ext" could also mean
extended for example.

https://codereview.chromium.org/2297303004/diff/1/xfa/fgas/font/fgas_gefont.h
File xfa/fgas/font/fgas_gefont.h (right):

https://codereview.chromium.org/2297303004/diff/1/xfa/fgas/font/fgas_gefont.h...
xfa/fgas/font/fgas_gefont.h:28: bool bExternalFont,
Can we add a separate LoadInternalFont(CFX_Font* pSrcFont, IFGAS_FontMgr*
pFontMgr) method instead of a bool parameter? We can make LoadInternalFont()
take a std::unique_ptr at some point to indicate transfer of ownership.

[Wei Li, 2016-09-01 23:27:36]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 23:27:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wei Li, 2016-09-01 23:27:49]

Patchset #2 (id:20001) has been deleted

[Wei Li, 2016-09-01 23:41:37]

Patchset #2 (id:40001) has been deleted

[Wei Li, 2016-09-01 23:43:30]

change to the new approach

https://codereview.chromium.org/2297303004/diff/1/xfa/fgas/font/fgas_gefont.cpp
File xfa/fgas/font/fgas_gefont.cpp (right):

https://codereview.chromium.org/2297303004/diff/1/xfa/fgas/font/fgas_gefont.c...
xfa/fgas/font/fgas_gefont.cpp:218: m_bExtFont = bExternalFont;
On 2016/09/01 22:55:42, Lei Zhang wrote:
> Can we name |m_bExtFont| to |m_bExternalFont| later? "ext" could also mean
> extended for example.

Done.

https://codereview.chromium.org/2297303004/diff/1/xfa/fgas/font/fgas_gefont.h
File xfa/fgas/font/fgas_gefont.h (right):

https://codereview.chromium.org/2297303004/diff/1/xfa/fgas/font/fgas_gefont.h...
xfa/fgas/font/fgas_gefont.h:28: bool bExternalFont,
On 2016/09/01 22:55:42, Lei Zhang wrote:
> Can we add a separate LoadInternalFont(CFX_Font* pSrcFont, IFGAS_FontMgr*
> pFontMgr) method instead of a bool parameter? We can make LoadInternalFont()
> take a std::unique_ptr at some point to indicate transfer of ownership.

Done.

[Lei Zhang, 2016-09-01 23:51:30]

++lgtm

[Wei Li, 2016-09-01 23:56:48]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 23:56:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 00:05:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 00:06:00]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-09-02 00:09:54]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-09-02 00:09:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 00:10:17]

Description was changed from

==========
Fix leaked internal font

In CFGAS_FontMgrImp::LoadFont(), a new internal font is created which
is never released. It needs to be correctly marked as internal font to
be released. Fix this by adding a boolean parameter and pass it along
during the creation of the font.

BUG=pdfium:242
==========

to

==========
Fix leaked internal font

In CFGAS_FontMgrImp::LoadFont(), a new internal font is created which
is never released. It needs to be correctly marked as internal font to
be released. Fix this by adding a boolean parameter and pass it along
during the creation of the font.

BUG=pdfium:242

Committed:
https://pdfium.googlesource.com/pdfium/+/6708106e6a3d54f3370c871ebf6643d1ecf5...
==========

[commit-bot: I haz the power, 2016-09-02 00:10:18]

Committed patchset #2 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/6708106e6a3d54f3370c871ebf6643d1ecf5...

[Wei Li, 2016-09-02 00:41:54]

A revert of this CL (patchset #2 id:60001) has been created in
https://codereview.chromium.org/2302213002/ by weili@chromium.org.

The reason for reverting is: asan bot doesn't like it, will investigate.