Fix bug with nested spreads as patterns

Fix bug with nested spreads as patterns

R=adamk@chromium.org, littledan@chromium.org
BUG=v8:5337
LOG=N

Committed: https://crrev.com/628e9e3eb85cea3cb7c9067b89a948298b021215
Cr-Commit-Position: refs/heads/master@{#39118}

[nickie, 2016-09-01 15:30:14]

The CQ bit was checked by nikolaos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 15:30:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nickie, 2016-09-01 15:31:19]

Description was changed from

==========
Fix bug with nested spreads as patterns

R=adamk@chromium.org, littledan@chromium.org
BUG=v8:5337
LOG=N
==========

to

==========
Fix bug with nested spreads as patterns

R=adamk@chromium.org, littledan@chromium.org
BUG=v8:5337
LOG=N
==========

[caitp, 2016-09-01 15:34:40]

caitp@igalia.com changed reviewers:
+ caitp@igalia.com

[caitp, 2016-09-01 15:34:41]

https://codereview.chromium.org/2297303003/diff/1/src/parsing/pattern-rewrite...
File src/parsing/pattern-rewriter.cc (right):

https://codereview.chromium.org/2297303003/diff/1/src/parsing/pattern-rewrite...
src/parsing/pattern-rewriter.cc:271: return Visit(node->expression());
my understanding is, this will recursively continue the rewriting from the
Visit(node->expression()) 2 lines above this, right?

I think it looks okay, but I'm not sure why the nested pattern would be a
RewritableExpression in the first place

[nickie, 2016-09-01 15:38:52]

On 2016/09/01 15:34:41, caitp wrote:
>
https://codereview.chromium.org/2297303003/diff/1/src/parsing/pattern-rewrite...
> File src/parsing/pattern-rewriter.cc (right):
> 
>
https://codereview.chromium.org/2297303003/diff/1/src/parsing/pattern-rewrite...
> src/parsing/pattern-rewriter.cc:271: return Visit(node->expression());
> my understanding is, this will recursively continue the rewriting from the
> Visit(node->expression()) 2 lines above this, right?

Yes.  This is equivalent to what we were doing before, only in the case that we
don't have an assignment the expression is not flagged as rewritten.

> I think it looks okay, but I'm not sure why the nested pattern would be a
> RewritableExpression in the first place

We use RewritableExpressions for two reasons: pattern rewriting (i.e.,
destructuring assignment) and non-pattern rewriting (spreads in expressions). 
The inner spread is wrapped in a RewritableExpression because when we parsed it
we didn't know if it was a pattern or a non-pattern.

[commit-bot: I haz the power, 2016-09-01 15:42:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 15:42:21]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[adamk, 2016-09-01 17:16:44]

lgtm, thanks for the quick fix!

[nickie, 2016-09-02 07:25:01]

The CQ bit was checked by nikolaos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 07:25:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 07:48:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 07:48:13]

Dry run: This issue passed the CQ dry run.

[nickie, 2016-09-02 07:49:58]

The CQ bit was checked by nikolaos@chromium.org

[commit-bot: I haz the power, 2016-09-02 07:50:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 07:52:21]

Description was changed from

==========
Fix bug with nested spreads as patterns

R=adamk@chromium.org, littledan@chromium.org
BUG=v8:5337
LOG=N
==========

to

==========
Fix bug with nested spreads as patterns

R=adamk@chromium.org, littledan@chromium.org
BUG=v8:5337
LOG=N
==========

[commit-bot: I haz the power, 2016-09-02 07:52:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-02 07:53:05]

Description was changed from

==========
Fix bug with nested spreads as patterns

R=adamk@chromium.org, littledan@chromium.org
BUG=v8:5337
LOG=N
==========

to

==========
Fix bug with nested spreads as patterns

R=adamk@chromium.org, littledan@chromium.org
BUG=v8:5337
LOG=N

Committed: https://crrev.com/628e9e3eb85cea3cb7c9067b89a948298b021215
Cr-Commit-Position: refs/heads/master@{#39118}
==========

[commit-bot: I haz the power, 2016-09-02 07:53:06]

Patchset 1 (id:??) landed as
https://crrev.com/628e9e3eb85cea3cb7c9067b89a948298b021215
Cr-Commit-Position: refs/heads/master@{#39118}