create selectors directly from method invocations in kernel -> ssa

create selectors directly from method invocations in kernel -> ssa

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/2ee580718497f559984145bf5dae9aea17245515

[Harry Terkelsen, 2016-08-31 17:37:37]

het@google.com changed reviewers:
+ sigmund@google.com

[Harry Terkelsen, 2016-08-31 17:38:47]

Description was changed from

==========
create selectors directly from method invocations in kernel -> ssa

BUG=
==========

to

==========
create selectors directly from method invocations in kernel -> ssa

BUG=
==========

[Siggi Cherem (dart-lang), 2016-08-31 17:42:37]

lgtm, yay

https://codereview.chromium.org/2297283002/diff/1/pkg/compiler/lib/src/ssa/ke...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2297283002/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:89: // TODO(het): If this is a
private name, include the library
remove TODO? Or is this something more than what you have below?

https://codereview.chromium.org/2297283002/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:93: new
Name(invocation.name.name, getElement(invocation.name.library));
minor style nit, consider:

ir.Name irName = invocation.name;
Name name = new Name(irName.name,
    irName.isPrivate ? getElement(originalName.library) : null);

[Harry Terkelsen, 2016-08-31 17:45:58]

thanks, Siggi!

https://codereview.chromium.org/2297283002/diff/1/pkg/compiler/lib/src/ssa/ke...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2297283002/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:89: // TODO(het): If this is a
private name, include the library
On 2016/08/31 17:42:36, Siggi Cherem (dart-lang) wrote:
> remove TODO? Or is this something more than what you have below?

Oops! I forgot to remove once I actually did it

https://codereview.chromium.org/2297283002/diff/1/pkg/compiler/lib/src/ssa/ke...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:93: new
Name(invocation.name.name, getElement(invocation.name.library));
On 2016/08/31 17:42:36, Siggi Cherem (dart-lang) wrote:
> minor style nit, consider:
> 
> ir.Name irName = invocation.name;
> Name name = new Name(irName.name,
>     irName.isPrivate ? getElement(originalName.library) : null);

Done.

[Harry Terkelsen, 2016-08-31 17:46:34]

Description was changed from

==========
create selectors directly from method invocations in kernel -> ssa

BUG=
==========

to

==========
create selectors directly from method invocations in kernel -> ssa

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2ee580718497f559984145bf5dae9aea17245515
==========

[Harry Terkelsen, 2016-08-31 17:46:36]

Committed patchset #3 (id:40001) manually as
2ee580718497f559984145bf5dae9aea17245515 (presubmit successful).