Revert "Revert of content: Fix Context creation logic in ContextProviderFactoryImpl. (patchset #10 …

Revert "Revert of content: Fix Context creation logic in ContextProviderFactoryImpl. (patchset #10 id:180001 of https://codereview.chromium.org/2250473005/ )"

This reverts commit 258820db7532d4c411c2000c0907c6cb35399c03.

TBR = dtrainor
BUG=643199, 643282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3
Cr-Commit-Position: refs/heads/master@{#416062}

[Khushal, 2016-09-01 17:36:07]

Description was changed from

==========
Revert "Revert of content: Fix Context creation logic in
ContextProviderFactoryImpl. (patchset #10 id:180001 of
https://codereview.chromium.org/2250473005/ )"

This reverts commit 258820db7532d4c411c2000c0907c6cb35399c03.

BUG=643199
==========

to

==========
Revert "Revert of content: Fix Context creation logic in
ContextProviderFactoryImpl. (patchset #10 id:180001 of
https://codereview.chromium.org/2250473005/ )"

This reverts commit 258820db7532d4c411c2000c0907c6cb35399c03.

BUG=643199
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Khushal, 2016-09-01 19:05:29]

Description was changed from

==========
Revert "Revert of content: Fix Context creation logic in
ContextProviderFactoryImpl. (patchset #10 id:180001 of
https://codereview.chromium.org/2250473005/ )"

This reverts commit 258820db7532d4c411c2000c0907c6cb35399c03.

BUG=643199
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert "Revert of content: Fix Context creation logic in
ContextProviderFactoryImpl. (patchset #10 id:180001 of
https://codereview.chromium.org/2250473005/ )"

This reverts commit 258820db7532d4c411c2000c0907c6cb35399c03.

BUG=643199, 643282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Khushal, 2016-09-01 19:09:56]

khushalsagar@chromium.org changed reviewers:
+ piman@chromium.org

[Khushal, 2016-09-01 19:09:57]

There was a misplaced DCHECK for the shutdown case, moved it to if the caller
makes a new request while we are running callbacks during shutdown.

For the failure in GpuProcess.no_gpu_process, I just restored the behaviour to
what it was earlier. The original change was logging FATAL if the Gpu process
initialization would fail twice in a row instead of continually trying again,
which is bound to fail for the no_gpu_process case.

PTAL.

[piman, 2016-09-01 19:23:53]

lgtm

[Khushal, 2016-09-01 19:28:54]

Description was changed from

==========
Revert "Revert of content: Fix Context creation logic in
ContextProviderFactoryImpl. (patchset #10 id:180001 of
https://codereview.chromium.org/2250473005/ )"

This reverts commit 258820db7532d4c411c2000c0907c6cb35399c03.

BUG=643199, 643282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert "Revert of content: Fix Context creation logic in
ContextProviderFactoryImpl. (patchset #10 id:180001 of
https://codereview.chromium.org/2250473005/ )"

This reverts commit 258820db7532d4c411c2000c0907c6cb35399c03.

TBR = dtrainor
BUG=643199, 643282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Khushal, 2016-09-01 19:29:02]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2016-09-01 19:29:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 21:34:32]

Description was changed from

==========
Revert "Revert of content: Fix Context creation logic in
ContextProviderFactoryImpl. (patchset #10 id:180001 of
https://codereview.chromium.org/2250473005/ )"

This reverts commit 258820db7532d4c411c2000c0907c6cb35399c03.

TBR = dtrainor
BUG=643199, 643282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert "Revert of content: Fix Context creation logic in
ContextProviderFactoryImpl. (patchset #10 id:180001 of
https://codereview.chromium.org/2250473005/ )"

This reverts commit 258820db7532d4c411c2000c0907c6cb35399c03.

TBR = dtrainor
BUG=643199, 643282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-09-01 21:34:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-01 21:38:04]

Description was changed from

==========
Revert "Revert of content: Fix Context creation logic in
ContextProviderFactoryImpl. (patchset #10 id:180001 of
https://codereview.chromium.org/2250473005/ )"

This reverts commit 258820db7532d4c411c2000c0907c6cb35399c03.

TBR = dtrainor
BUG=643199, 643282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert "Revert of content: Fix Context creation logic in
ContextProviderFactoryImpl. (patchset #10 id:180001 of
https://codereview.chromium.org/2250473005/ )"

This reverts commit 258820db7532d4c411c2000c0907c6cb35399c03.

TBR = dtrainor
BUG=643199, 643282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3
Cr-Commit-Position: refs/heads/master@{#416062}
==========

[commit-bot: I haz the power, 2016-09-01 21:38:05]

Patchset 2 (id:??) landed as
https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3
Cr-Commit-Position: refs/heads/master@{#416062}

[ynovikov, 2016-09-02 01:18:55]

On 2016/09/01 21:38:05, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3
> Cr-Commit-Position: refs/heads/master@{#416062}

GpuProcess.no_gpu_process is still failing. I guess we need Revert Revert Revert
:)

[Khushal, 2016-09-02 01:20:33]

On 2016/09/02 01:18:55, ynovikov wrote:
> On 2016/09/01 21:38:05, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/f279cb2138fcfc9eddd37d99440c55bbb783f8b3
> > Cr-Commit-Position: refs/heads/master@{#416062}
> 
> GpuProcess.no_gpu_process is still failing. I guess we need Revert Revert
Revert
> :)

Yeah, I was watching the bots too to make sure. Reverting.

[Khushal, 2016-09-02 01:21:47]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2299333003/ by khushalsagar@chromium.org.

The reason for reverting is: The test is still failing..