Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2297253002: [elements] Fix GetEntryForIndexImpl to honor array length (Closed)

Created:
4 years, 3 months ago by Jakob Kummerow
Modified:
4 years, 3 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[elements] Fix GetEntryForIndexImpl to honor array length Previously, fast holey elements accessors would detect element presence by simply doing a hole check on any slot within the backing store's capacity. This relied on the (mostly-true but brittle) assumption that slots beyond the length are always correctly zapped with The Hole. Committed: https://crrev.com/e1cb5622246245901bf1e98e7c2b80d16338d67b Cr-Commit-Position: refs/heads/master@{#39051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M src/elements.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/element-accessor.js View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
PTAL.
4 years, 3 months ago (2016-08-31 17:07:40 UTC) #2
Camillo Bruni
lgtm
4 years, 3 months ago (2016-08-31 17:13:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297253002/1
4 years, 3 months ago (2016-08-31 17:15:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 17:46:04 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 17:46:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1cb5622246245901bf1e98e7c2b80d16338d67b
Cr-Commit-Position: refs/heads/master@{#39051}

Powered by Google App Engine
This is Rietveld 408576698