Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2297243002: Don't crash if WebAXObject::characterOffsets doesn't return any bounds. (Closed)

Created:
4 years, 3 months ago by dmazzoni
Modified:
4 years, 3 months ago
Reviewers:
aboxhall
CC:
chromium-reviews, einbinder+watch-test-runner_chromium.org, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't crash if WebAXObject::characterOffsets doesn't return any bounds. This is just a fix in the test_runner, it had a DCHECK if we requested character bounds for an element that wasn't able to return any, but clusterfuzz treated that as a crash. BUG=638220 Committed: https://crrev.com/1c7b9c439b6a0437e724d5a22311f81287d74a21 Cr-Commit-Position: refs/heads/master@{#416068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M components/test_runner/web_ax_object_proxy.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dmazzoni
4 years, 3 months ago (2016-08-31 17:04:12 UTC) #2
aboxhall
lgtm
4 years, 3 months ago (2016-09-01 19:59:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297243002/1
4 years, 3 months ago (2016-09-01 20:13:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 21:45:16 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 21:47:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c7b9c439b6a0437e724d5a22311f81287d74a21
Cr-Commit-Position: refs/heads/master@{#416068}

Powered by Google App Engine
This is Rietveld 408576698