Better error reasons for rAc

components/autofill/core/browser/autofill_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/format_macros.h"
 #include "base/memory/ref_counted.h"
@@ skipping 2839 matching lines @@
 
 class MockAutofillManagerDelegate : public TestAutofillManagerDelegate {
  public:
   MockAutofillManagerDelegate() {}
 
   virtual ~MockAutofillManagerDelegate() {}
 
   virtual void ShowRequestAutocompleteDialog(
       const FormData& form,
       const GURL& source_url,
-      const base::Callback<void(const FormStructure*)>& callback) OVERRIDE {
-    callback.Run(user_supplied_data_.get());
+      const ResultCallback& callback) OVERRIDE {
+    callback.Run(user_supplied_data_ ? AutocompleteResultSuccess :

[blundell, 2014/04/10 08:03:40]

These need to be prefixed by AutofillManagerDelegate:: , right?

[Evan Stade, 2014/04/10 16:38:58]

No, because |this| inherits from AutofillManagerDelegate

+                                       AutocompleteResultErrorDisabled,
+                 user_supplied_data_.get());
   }
 
   void SetUserSuppliedData(scoped_ptr<FormStructure> user_supplied_data) {
     user_supplied_data_.reset(user_supplied_data.release());
   }
 
  private:
   scoped_ptr<FormStructure> user_supplied_data_;
 
- DISALLOW_COPY_AND_ASSIGN(MockAutofillManagerDelegate);
+  DISALLOW_COPY_AND_ASSIGN(MockAutofillManagerDelegate);
 };
 
 }  // namespace
 
 // Test our external delegate is called at the right time.
 TEST_F(AutofillManagerTest, TestExternalDelegate) {
   FormData form;
   test::CreateTestAddressFormData(&form);
   std::vector<FormData> forms(1, form);
   FormsSeen(forms);
   const FormFieldData& field = form.fields[0];
   GetAutofillSuggestions(form, field);  // should call the delegate's OnQuery()
 
   EXPECT_TRUE(external_delegate_->on_query_seen());
 }
 
 }  // namespace autofill