Better error reasons for rAc

chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/tab_autofill_manager_delegate.h"
 
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/autofill/autofill_cc_infobar_delegate.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
@@ skipping 79 matching lines @@
     const base::Closure& save_card_callback) {
   InfoBarService* infobar_service =
       InfoBarService::FromWebContents(web_contents_);
   AutofillCCInfoBarDelegate::Create(
       infobar_service, &metric_logger, save_card_callback);
 }
 
 void TabAutofillManagerDelegate::ShowRequestAutocompleteDialog(
     const FormData& form,
     const GURL& source_url,
-    const base::Callback<void(const FormStructure*)>& callback) {
+    const ResultCallback& callback) {
   HideRequestAutocompleteDialog();
 
   dialog_controller_ = AutofillDialogController::Create(web_contents_,
                                                         form,
                                                         source_url,
                                                         callback);
   if (dialog_controller_) {
     dialog_controller_->Show();
   } else {
-    callback.Run(NULL);
+    callback.Run(AutofillManagerDelegate::AutocompleteResultErrorDisabled,

[Evan Stade, 2014/04/09 22:11:15]

^behavioral change (previously this would have counted as "cancel")

+                 NULL);
     NOTIMPLEMENTED();
   }
 }
 
 void TabAutofillManagerDelegate::ShowAutofillPopup(
     const gfx::RectF& element_bounds,
     base::i18n::TextDirection text_direction,
     const std::vector<base::string16>& values,
     const std::vector<base::string16>& labels,
     const std::vector<base::string16>& icons,
@@ skipping 63 matching lines @@
 void TabAutofillManagerDelegate::DidFillOrPreviewField(
     const base::string16& autofilled_value,
     const base::string16& profile_full_name) {
 #if defined(OS_ANDROID)
   AutofillLoggerAndroid::DidFillOrPreviewField(
       autofilled_value, profile_full_name);
 #endif  // defined(OS_ANDROID)
 }
 
 }  // namespace autofill