components/autofill/core/browser/DEPS - Issue 229723002: Better error reasons for rAc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/core/browser/DEPS

Issue 229723002: Better error reasons for rAc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/keyed_service/core",	2 "+components/keyed_service/core",

3 "+components/webdata/common",	3 "+components/webdata/common",

4 "+crypto/random.h",	4 "+crypto/random.h",

5 "+google_apis/gaia",	5 "+google_apis/gaia",

6 "+google_apis/google_api_keys.h",	6 "+google_apis/google_api_keys.h",

7 "+net",	7 "+net",

8 "+sql",	8 "+sql",

9 "+third_party/libjingle",	9 "+third_party/libjingle",

10 "+third_party/libphonenumber", # For phone number i18n.	10 "+third_party/libphonenumber", # For phone number i18n.

	11 "+third_party/WebKit/public/web",
	Evan Stade 2014/04/08 23:38:52 Colin, is this include OK? It's needed for the Web Colin, is this include OK? It's needed for the WebFormElement::AutocompleteResult type. The alternative is to make a copy of that enum. blundell 2014/04/09 09:09:46 It's not OK, unfortunately: third_party/WebKit/pub It's not OK, unfortunately: third_party/WebKit/public is essentially the same as content/public from the POV of the iOS port. On 2014/04/08 23:38:52, Evan Stade wrote: Show quoted text > Colin, is this include OK? It's needed for the > WebFormElement::AutocompleteResult type. The alternative is to make a copy of > that enum.
11 ]	12 ]

OLD	NEW