third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.cpp - Issue 2297213003: Fix CSS reference filters with negative transformed children.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.cpp

Issue 2297213003: Fix CSS reference filters with negative transformed children. (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h ('k') | third_party/WebKit/public/platform/WebDisplayItemList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.cpp b/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.cpp

index 242885f638f98a1a4028f3284d1756c7199b4157..46478e83578e1ba0402c664b3c4d2f9f4426dfa9 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.cpp

@@ -11,16 +11,17 @@ namespace blink {

void BeginFilterDisplayItem::replay(GraphicsContext& context) const

{

- FloatRect imageFilterBounds(FloatPoint(), m_bounds.size());

+ FloatRect imageFilterBounds(m_bounds);

+ imageFilterBounds.move(-m_origin.x(), -m_origin.y());

context.save();

- context.translate(m_bounds.x(), m_bounds.y());

+ context.translate(m_origin.x(), m_origin.y());

context.beginLayer(1, SkXfermode::kSrcOver_Mode, &imageFilterBounds, ColorFilterNone, m_imageFilter);

- context.translate(-m_bounds.x(), -m_bounds.y());

+ context.translate(-m_origin.x(), -m_origin.y());

}

void BeginFilterDisplayItem::appendToWebDisplayItemList(const IntRect& visualRect, WebDisplayItemList* list) const

{

- list->appendFilterItem(m_compositorFilterOperations.asCcFilterOperations(), m_bounds);

+ list->appendFilterItem(m_compositorFilterOperations.asCcFilterOperations(), m_bounds, m_origin);

}

bool BeginFilterDisplayItem::drawsContent() const