Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 22972002: Finish making FloatingObject a real class with private members (Closed)

Created:
7 years, 4 months ago by eseidel
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Finish making FloatingObject a real class with private members Previously FloatingObject was in a half-done state where it had accessors for many members, but also many members were public. This CL makes all members private and adds the necessary remaining accessors. As I toured the float code (while writing this CL) it became clear to me that this code is very fragile/dangerous and needs to have better memory management, and see if we can get away with not having all these raw pointers to other renders (or lineboxes!) which if we're not careful could go stale during a layout or style resolve. BUG=271774 R=zoltan@adobe.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -63 lines) Patch
M Source/core/rendering/RenderBlock.h View 4 chunks +14 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 22 chunks +48 lines, -46 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 6 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eseidel
7 years, 4 months ago (2013-08-12 23:07:18 UTC) #1
Zoltan
The change looks good to me. Do we have an issue to track the floats ...
7 years, 4 months ago (2013-08-12 23:21:39 UTC) #2
eseidel
No, but I'm happy to make one.
7 years, 4 months ago (2013-08-12 23:27:58 UTC) #3
Zoltan
lgtm
7 years, 4 months ago (2013-08-12 23:30:19 UTC) #4
eseidel
7 years, 4 months ago (2013-08-12 23:35:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r155964 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698