Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 2297193005: Don't ignore passed attributes in InstallGetterSetter (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't ignore passed attributes in InstallGetterSetter Up until now, the passed attributes were completely ignored and we defaulted to DONT_ENUM every time. BUG= Committed: https://crrev.com/69debbb50c0ad62aba37c410c0aa917211805839 Cr-Commit-Position: refs/heads/master@{#39091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/js/prologue.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
jgruber
It may be the case that a couple of layout test expectations will become incorrect ...
4 years, 3 months ago (2016-09-01 13:18:40 UTC) #4
Jakob Kummerow
LGTM. Please run layout tests before landing (there are try bots), otherwise this could block ...
4 years, 3 months ago (2016-09-01 13:21:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297193005/1
4 years, 3 months ago (2016-09-01 14:50:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 14:52:27 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 14:53:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69debbb50c0ad62aba37c410c0aa917211805839
Cr-Commit-Position: refs/heads/master@{#39091}

Powered by Google App Engine
This is Rietveld 408576698