chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java - Issue 2297193003: Extract browser shared class initialization from ChromeApplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java

Issue 2297193003: Extract browser shared class initialization from ChromeApplication. (Closed)

Patch Set: Moar test fixes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java b/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java

index 67bdfd845f42cfec77e86b279e96ba294bbd50d2..f762e04f4a3420f89d06a177c472c0fb93e08821 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java

@@ -119,10 +119,9 @@ public class ChromeBrowserInitializer {

public void handleSynchronousStartup() throws ProcessInitException {

assert ThreadUtils.runningOnUiThread() : "Tried to start the browser on the wrong thread";

- ChromeBrowserInitializer initializer = ChromeBrowserInitializer.getInstance(mApplication);

BrowserParts parts = new EmptyBrowserParts();

- initializer.handlePreNativeStartup(parts);

- initializer.handlePostNativeStartup(false, parts);

+ handlePreNativeStartup(parts);

+ handlePostNativeStartup(false, parts);

}

/**

@@ -134,6 +133,7 @@ public class ChromeBrowserInitializer {

public void handlePreNativeStartup(final BrowserParts parts) {

assert ThreadUtils.runningOnUiThread() : "Tried to start the browser on the wrong thread";

+ ProcessInitializationHandler.getInstance().initializePreNative();

preInflationStartup();

parts.preInflationStartup();

if (parts.isActivityFinishing()) return;