|
|
Created:
4 years, 3 months ago by Michael Tang Modified:
4 years, 3 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, apacible+watch_chromium.org, extensions-reviews_chromium.org, addison1 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWhitelist the APIs for chromeos/onhub recovery untility extensions.
The following APIs are whitelisted:
- imageWriterPrivate
- chromeosInfoPrivate
- the feedback API
- fileSystem
BUG=642141
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/2f83bcda82ac58b93a793660e93fa1ce38ea6dac
Cr-Commit-Position: refs/heads/master@{#418487}
Patch Set 1 #Patch Set 2 : Whitelist the APIs for chromeos/onhub recovery untility extensions. #
Total comments: 2
Patch Set 3 : Whitelist the APIs for chromeos/onhub recovery untility extensions. #
Total comments: 2
Patch Set 4 : Whitelist the APIs for chromeos/onhub recovery untility extensions. #Patch Set 5 : Whitelist the APIs for chromeos/onhub recovery untility extensions. #Patch Set 6 : Whitelist the APIs for chromeos/onhub recovery untility extensions. #Patch Set 7 : Whitelist the APIs for chromeos/onhub recovery untility extensions. #Patch Set 8 : rebase and merge from origin/master #
Messages
Total messages: 69 (36 generated)
Description was changed from ========== Whitelist the APIs for chromeos/onhub recovery untility extensions. The following APIs are whitelisted: - imageWriterPrivate - chromeosInfoPrivate - the feedback API - fileSystem BUG=642141 ========== to ========== Whitelist the APIs for chromeos/onhub recovery untility extensions. The following APIs are whitelisted: - imageWriterPrivate - chromeosInfoPrivate - the feedback API - fileSystem BUG=642141 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Whitelist the APIs for chromeos/onhub recovery untility extensions. The following APIs are whitelisted: - imageWriterPrivate - chromeosInfoPrivate - the feedback API - fileSystem BUG=642141 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Whitelist the APIs for chromeos/onhub recovery untility extensions. The following APIs are whitelisted: - imageWriterPrivate - chromeosInfoPrivate - the feedback API - fileSystem BUG=642141 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
ntang@chromium.org changed reviewers: + rkc@chromium.org, stephenlin@chromium.org
ntang@chromium.org changed reviewers: + asargent@chromium.org
ntang@chromium.org changed reviewers: + steel@chromium.org
So I understand that the extension needs to be whitelisted for 'chrome.fileSystem', because though that was available to the recovery app, since it is now an extension, it needs to be whitelisted to have access. For the rest of the APIs though, wasn't the recovery app already whitelisted?
On 2016/09/08 19:45:49, Rahul Chaturvedi wrote: > So I understand that the extension needs to be whitelisted for > 'chrome.fileSystem', because though that was available to the recovery app, > since it is now an extension, it needs to be whitelisted to have access. For the > rest of the APIs though, wasn't the recovery app already whitelisted? For chrome.fileSystem, that is correct. For the rest of the APIs, they were whitelisted only for "apps" and not for "extensions". So we need to whitelist for the new extensiosn. Per our conversation offline, I added TODO to remove the whitelisting for "apps" when they are deprecated.
https://codereview.chromium.org/2297113002/diff/20001/chrome/browser/resource... File chrome/browser/resources/feedback/js/event_handler.js (right): https://codereview.chromium.org/2297113002/diff/20001/chrome/browser/resource... chrome/browser/resources/feedback/js/event_handler.js:75: // TODO (ntang) Removes after deprecation. TODO(ntang): Remove the following hashes by <insert date> at the latest. https://codereview.chromium.org/2297113002/diff/20001/chrome/common/extension... File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/2297113002/diff/20001/chrome/common/extension... chrome/common/extensions/api/_permission_features.json:126: // TODO(ntang) Remove Chrome Recovery Utility App after deprecation. Don't use app names - just use the format I specified in the other comment.
The CQ bit was checked by ntang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2016/09/09 17:06:27, Rahul Chaturvedi wrote: > https://codereview.chromium.org/2297113002/diff/20001/chrome/browser/resource... > File chrome/browser/resources/feedback/js/event_handler.js (right): > > https://codereview.chromium.org/2297113002/diff/20001/chrome/browser/resource... > chrome/browser/resources/feedback/js/event_handler.js:75: // TODO (ntang) > Removes after deprecation. > TODO(ntang): Remove the following hashes by <insert date> at the latest. > > https://codereview.chromium.org/2297113002/diff/20001/chrome/common/extension... > File chrome/common/extensions/api/_permission_features.json (right): > > https://codereview.chromium.org/2297113002/diff/20001/chrome/common/extension... > chrome/common/extensions/api/_permission_features.json:126: // TODO(ntang) > Remove Chrome Recovery Utility App after deprecation. > Don't use app names - just use the format I specified in the other comment. updated
12/31/2017 seems a bit excessive, but fine - we can resolve the actual date offline. lgtm
lgtm https://codereview.chromium.org/2297113002/diff/40001/chrome/browser/resource... File chrome/browser/resources/feedback/js/event_handler.js (right): https://codereview.chromium.org/2297113002/diff/40001/chrome/browser/resource... chrome/browser/resources/feedback/js/event_handler.js:75: // TODO (ntang) Removes the following hashes by 12/31/2017. grammar nit: s/Removes/Remove/ Also, do you mean that we should remove *all* of the hashes following your comment, or just that hashes that existed before, but we'd want to keep the last 2 you're adding in this CL? If the latter, you might want to revise the comment to something like "Remove the following 7 hashes ..." https://codereview.chromium.org/2297113002/diff/40001/chrome/common/extension... File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/2297113002/diff/40001/chrome/common/extension... chrome/common/extensions/api/_permission_features.json:126: // TODO (ntang) Removes the following hashes by 12/31/2017. same nit for this TODO comment (and elsewhere in this file)
On 2016/09/09 19:04:05, Antony Sargent wrote: > lgtm > > https://codereview.chromium.org/2297113002/diff/40001/chrome/browser/resource... > File chrome/browser/resources/feedback/js/event_handler.js (right): > > https://codereview.chromium.org/2297113002/diff/40001/chrome/browser/resource... > chrome/browser/resources/feedback/js/event_handler.js:75: // TODO (ntang) > Removes the following hashes by 12/31/2017. > grammar nit: s/Removes/Remove/ > > Also, do you mean that we should remove *all* of the hashes following your > comment, or just that hashes that existed before, but we'd want to keep the last > 2 you're adding in this CL? If the latter, you might want to revise the comment > to something like "Remove the following 7 hashes ..." > > https://codereview.chromium.org/2297113002/diff/40001/chrome/common/extension... > File chrome/common/extensions/api/_permission_features.json (right): > > https://codereview.chromium.org/2297113002/diff/40001/chrome/common/extension... > chrome/common/extensions/api/_permission_features.json:126: // TODO (ntang) > Removes the following hashes by 12/31/2017. > same nit for this TODO comment (and elsewhere in this file) Updated
The CQ bit was checked by ntang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from steel@chromium.org, asargent@chromium.org Link to the patchset: https://codereview.chromium.org/2297113002/#ps60001 (title: "Whitelist the APIs for chromeos/onhub recovery untility extensions.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by ntang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by ntang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ntang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ntang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ntang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from steel@chromium.org, asargent@chromium.org Link to the patchset: https://codereview.chromium.org/2297113002/#ps80001 (title: "Whitelist the APIs for chromeos/onhub recovery untility extensions.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ntang@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ntang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from steel@chromium.org, asargent@chromium.org Link to the patchset: https://codereview.chromium.org/2297113002/#ps100001 (title: "Whitelist the APIs for chromeos/onhub recovery untility extensions.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
On 2016/09/09 19:04:05, Antony Sargent wrote: > lgtm > > https://codereview.chromium.org/2297113002/diff/40001/chrome/browser/resource... > File chrome/browser/resources/feedback/js/event_handler.js (right): > > https://codereview.chromium.org/2297113002/diff/40001/chrome/browser/resource... > chrome/browser/resources/feedback/js/event_handler.js:75: // TODO (ntang) > Removes the following hashes by 12/31/2017. > grammar nit: s/Removes/Remove/ > > Also, do you mean that we should remove *all* of the hashes following your > comment, or just that hashes that existed before, but we'd want to keep the last > 2 you're adding in this CL? If the latter, you might want to revise the comment > to something like "Remove the following 7 hashes ..." > > https://codereview.chromium.org/2297113002/diff/40001/chrome/common/extension... > File chrome/common/extensions/api/_permission_features.json (right): > > https://codereview.chromium.org/2297113002/diff/40001/chrome/common/extension... > chrome/common/extensions/api/_permission_features.json:126: // TODO (ntang) > Removes the following hashes by 12/31/2017. > same nit for this TODO comment (and elsewhere in this file) Antony & Rahul, Do you know why commit queue always fail for this CL? I did the rebase and re-upload a few times, still could not get it in? Any suggestion?
How are you doing the rebase/re-upload? It doesn't look like the code review tool is seeing your rebase.
On 2016/09/13 22:54:31, Rahul Chaturvedi wrote: > How are you doing the rebase/re-upload? It doesn't look like the code review > tool is seeing your rebase. under chromium/src: git rebase-update git cl upload
The CQ bit was checked by ntang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from steel@chromium.org, asargent@chromium.org Link to the patchset: https://codereview.chromium.org/2297113002/#ps120001 (title: "Whitelist the APIs for chromeos/onhub recovery untility extensions.")
On 2016/09/13 22:38:54, Michael Tang wrote: > On 2016/09/09 19:04:05, Antony Sargent wrote: > > lgtm > > > > > https://codereview.chromium.org/2297113002/diff/40001/chrome/browser/resource... > > File chrome/browser/resources/feedback/js/event_handler.js (right): > > > > > https://codereview.chromium.org/2297113002/diff/40001/chrome/browser/resource... > > chrome/browser/resources/feedback/js/event_handler.js:75: // TODO (ntang) > > Removes the following hashes by 12/31/2017. > > grammar nit: s/Removes/Remove/ > > > > Also, do you mean that we should remove *all* of the hashes following your > > comment, or just that hashes that existed before, but we'd want to keep the > last > > 2 you're adding in this CL? If the latter, you might want to revise the > comment > > to something like "Remove the following 7 hashes ..." > > > > > https://codereview.chromium.org/2297113002/diff/40001/chrome/common/extension... > > File chrome/common/extensions/api/_permission_features.json (right): > > > > > https://codereview.chromium.org/2297113002/diff/40001/chrome/common/extension... > > chrome/common/extensions/api/_permission_features.json:126: // TODO (ntang) > > Removes the following hashes by 12/31/2017. > > same nit for this TODO comment (and elsewhere in this file) > > Antony & Rahul, Do you know why commit queue always fail for this CL? I did the > rebase and re-upload a few times, still could not get it in? Any suggestion? Hmm, you can see the patch failures for one of the builders at: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... Looks like a real error - are you sure you resolved the merge properly? If you create a new test branch off of origin/master and then try doing 'git cl patch 2297113002' to patch in the changes from this CL to it, do they apply cleanly to your test branch?
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ntang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from steel@chromium.org, asargent@chromium.org Link to the patchset: https://codereview.chromium.org/2297113002/#ps140001 (title: "rebase and merge from origin/master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by ntang@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Whitelist the APIs for chromeos/onhub recovery untility extensions. The following APIs are whitelisted: - imageWriterPrivate - chromeosInfoPrivate - the feedback API - fileSystem BUG=642141 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Whitelist the APIs for chromeos/onhub recovery untility extensions. The following APIs are whitelisted: - imageWriterPrivate - chromeosInfoPrivate - the feedback API - fileSystem BUG=642141 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001)
Message was sent while issue was closed.
Description was changed from ========== Whitelist the APIs for chromeos/onhub recovery untility extensions. The following APIs are whitelisted: - imageWriterPrivate - chromeosInfoPrivate - the feedback API - fileSystem BUG=642141 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Whitelist the APIs for chromeos/onhub recovery untility extensions. The following APIs are whitelisted: - imageWriterPrivate - chromeosInfoPrivate - the feedback API - fileSystem BUG=642141 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2f83bcda82ac58b93a793660e93fa1ce38ea6dac Cr-Commit-Position: refs/heads/master@{#418487} ==========
Message was sent while issue was closed.
Patchset 8 (id:??) landed as https://crrev.com/2f83bcda82ac58b93a793660e93fa1ce38ea6dac Cr-Commit-Position: refs/heads/master@{#418487} |