Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2297113002: Whitelist the APIs for chromeos/onhub recovery untility extensions. (Closed)

Created:
4 years, 3 months ago by Michael Tang
Modified:
4 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, apacible+watch_chromium.org, extensions-reviews_chromium.org, addison1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelist the APIs for chromeos/onhub recovery untility extensions. The following APIs are whitelisted: - imageWriterPrivate - chromeosInfoPrivate - the feedback API - fileSystem BUG=642141 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2f83bcda82ac58b93a793660e93fa1ce38ea6dac Cr-Commit-Position: refs/heads/master@{#418487}

Patch Set 1 #

Patch Set 2 : Whitelist the APIs for chromeos/onhub recovery untility extensions. #

Total comments: 2

Patch Set 3 : Whitelist the APIs for chromeos/onhub recovery untility extensions. #

Total comments: 2

Patch Set 4 : Whitelist the APIs for chromeos/onhub recovery untility extensions. #

Patch Set 5 : Whitelist the APIs for chromeos/onhub recovery untility extensions. #

Patch Set 6 : Whitelist the APIs for chromeos/onhub recovery untility extensions. #

Patch Set 7 : Whitelist the APIs for chromeos/onhub recovery untility extensions. #

Patch Set 8 : rebase and merge from origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M chrome/browser/resources/feedback/js/event_handler.js View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 3 4 5 6 7 5 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 69 (36 generated)
Rahul Chaturvedi
So I understand that the extension needs to be whitelisted for 'chrome.fileSystem', because though that ...
4 years, 3 months ago (2016-09-08 19:45:49 UTC) #6
Michael Tang
On 2016/09/08 19:45:49, Rahul Chaturvedi wrote: > So I understand that the extension needs to ...
4 years, 3 months ago (2016-09-09 16:56:32 UTC) #7
Rahul Chaturvedi
https://codereview.chromium.org/2297113002/diff/20001/chrome/browser/resources/feedback/js/event_handler.js File chrome/browser/resources/feedback/js/event_handler.js (right): https://codereview.chromium.org/2297113002/diff/20001/chrome/browser/resources/feedback/js/event_handler.js#newcode75 chrome/browser/resources/feedback/js/event_handler.js:75: // TODO (ntang) Removes after deprecation. TODO(ntang): Remove the ...
4 years, 3 months ago (2016-09-09 17:06:27 UTC) #8
Michael Tang
On 2016/09/09 17:06:27, Rahul Chaturvedi wrote: > https://codereview.chromium.org/2297113002/diff/20001/chrome/browser/resources/feedback/js/event_handler.js > File chrome/browser/resources/feedback/js/event_handler.js (right): > > https://codereview.chromium.org/2297113002/diff/20001/chrome/browser/resources/feedback/js/event_handler.js#newcode75 ...
4 years, 3 months ago (2016-09-09 17:23:19 UTC) #13
Rahul Chaturvedi
12/31/2017 seems a bit excessive, but fine - we can resolve the actual date offline. ...
4 years, 3 months ago (2016-09-09 18:04:06 UTC) #14
asargent_no_longer_on_chrome
lgtm https://codereview.chromium.org/2297113002/diff/40001/chrome/browser/resources/feedback/js/event_handler.js File chrome/browser/resources/feedback/js/event_handler.js (right): https://codereview.chromium.org/2297113002/diff/40001/chrome/browser/resources/feedback/js/event_handler.js#newcode75 chrome/browser/resources/feedback/js/event_handler.js:75: // TODO (ntang) Removes the following hashes by ...
4 years, 3 months ago (2016-09-09 19:04:05 UTC) #15
Michael Tang
On 2016/09/09 19:04:05, Antony Sargent wrote: > lgtm > > https://codereview.chromium.org/2297113002/diff/40001/chrome/browser/resources/feedback/js/event_handler.js > File chrome/browser/resources/feedback/js/event_handler.js (right): ...
4 years, 3 months ago (2016-09-09 21:46:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297113002/60001
4 years, 3 months ago (2016-09-09 21:47:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297113002/60001
4 years, 3 months ago (2016-09-09 21:48:54 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/66911) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-09 21:50:57 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297113002/60001
4 years, 3 months ago (2016-09-10 00:42:56 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/266480) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-10 00:45:49 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297113002/60001
4 years, 3 months ago (2016-09-12 16:35:40 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/67479) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-12 16:38:04 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297113002/60001
4 years, 3 months ago (2016-09-12 22:04:54 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/127702) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-12 22:08:30 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297113002/80001
4 years, 3 months ago (2016-09-12 22:09:53 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/127709) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-12 22:13:43 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297113002/80001
4 years, 3 months ago (2016-09-13 04:05:04 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/267416) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-13 04:07:20 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297113002/100001
4 years, 3 months ago (2016-09-13 04:17:05 UTC) #47
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/67979)
4 years, 3 months ago (2016-09-13 04:19:12 UTC) #49
Michael Tang
On 2016/09/09 19:04:05, Antony Sargent wrote: > lgtm > > https://codereview.chromium.org/2297113002/diff/40001/chrome/browser/resources/feedback/js/event_handler.js > File chrome/browser/resources/feedback/js/event_handler.js (right): ...
4 years, 3 months ago (2016-09-13 22:38:54 UTC) #50
Rahul Chaturvedi
How are you doing the rebase/re-upload? It doesn't look like the code review tool is ...
4 years, 3 months ago (2016-09-13 22:54:31 UTC) #51
Michael Tang
On 2016/09/13 22:54:31, Rahul Chaturvedi wrote: > How are you doing the rebase/re-upload? It doesn't ...
4 years, 3 months ago (2016-09-13 22:58:12 UTC) #52
asargent_no_longer_on_chrome
On 2016/09/13 22:38:54, Michael Tang wrote: > On 2016/09/09 19:04:05, Antony Sargent wrote: > > ...
4 years, 3 months ago (2016-09-13 22:58:56 UTC) #55
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297113002/120001
4 years, 3 months ago (2016-09-13 22:59:26 UTC) #56
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/156517) ios-device on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-13 23:03:07 UTC) #58
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297113002/140001
4 years, 3 months ago (2016-09-14 00:04:38 UTC) #61
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/295755)
4 years, 3 months ago (2016-09-14 02:23:47 UTC) #63
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297113002/140001
4 years, 3 months ago (2016-09-14 03:19:19 UTC) #65
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 3 months ago (2016-09-14 04:34:28 UTC) #67
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 04:37:52 UTC) #69
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/2f83bcda82ac58b93a793660e93fa1ce38ea6dac
Cr-Commit-Position: refs/heads/master@{#418487}

Powered by Google App Engine
This is Rietveld 408576698