Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java

Issue 2297073002: [Remoting Android] Move feedback type to radius logic out of DesktopView (Closed)
Patch Set: Reviewer's Feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java b/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
index af8f6fa82976e20f2ed25d0cdd1ac5663e02b1d2..d69fdf8cd66b907e7ba896b532dc16493e7d4f0d 100644
--- a/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
+++ b/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
@@ -17,6 +17,7 @@ import org.chromium.chromoting.jni.GlDisplay;
*/
public class GlDesktopView extends DesktopView implements SurfaceHolder.Callback {
private final GlDisplay mDisplay;
+ private final InputFeedbackRadiusMapper mMapper;
private Object mOnHostSizeChangedListenerKey;
private Object mOnCanvasRenderedListenerKey;
@@ -37,14 +38,14 @@ public class GlDesktopView extends DesktopView implements SurfaceHolder.Callback
}
};
- mScaleFactor = 0;
+ mMapper = new InputFeedbackRadiusMapper(this);
joedow 2016/08/31 22:14:12 mMapper isn't very descriptive. Perhaps mInputFee
Yuwei 2016/08/31 22:24:57 Done.
getHolder().addCallback(this);
}
@Override
public void showInputFeedback(InputFeedbackType feedbackToShow, PointF pos) {
- float diameter = getFeedbackRadius(feedbackToShow, mScaleFactor) * 2.0f;
+ float diameter = mMapper.getFeedbackRadius(feedbackToShow, mScaleFactor) * 2.0f;
if (diameter <= 0.0f) {
return;
}

Powered by Google App Engine
This is Rietveld 408576698