[Remoting Android] Move feedback type to radius logic out of DesktopView

remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java

Index: remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java b/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
index af8f6fa82976e20f2ed25d0cdd1ac5663e02b1d2..65467f98dac4816cad55c96711621caaa7f00402 100644
--- a/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
+++ b/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java
@@ -23,7 +23,9 @@ public class GlDesktopView extends DesktopView implements SurfaceHolder.Callback
 
     private Event.ParameterRunnable<Void> mProcessAnimationRunnable;
 
-    private float mScaleFactor;
+    private final InputFeedbackRadiusMapper mMapper;
+
+    private float mScaleFactor = 0;

[Hzj_jie, 2016/08/31 01:31:59]

I believe usually you do not need to actively initialize a float to 0. Java
itself will do it for you.

[Yuwei, 2016/08/31 01:36:13]

I think you are right... Remove this?

[Hzj_jie, 2016/08/31 01:38:43]

Yes, I suggest to do so to keep consistent. And I believe usually we put final
fields before others. So you may want to move mMapper before
mOnHostSizeChangedListenerKey.

[Yuwei, 2016/08/31 18:25:34]

Done.

 
     public GlDesktopView(GlDisplay display, Desktop desktop, Client client) {
         super(desktop, client);
@@ -37,14 +39,14 @@ public class GlDesktopView extends DesktopView implements SurfaceHolder.Callback
             }
         };
 
-        mScaleFactor = 0;
+        mMapper = new InputFeedbackRadiusMapper(this);
 
         getHolder().addCallback(this);
     }
 
     @Override
     public void showInputFeedback(InputFeedbackType feedbackToShow, PointF pos) {
-        float diameter = getFeedbackRadius(feedbackToShow, mScaleFactor) * 2.0f;
+        float diameter = mMapper.getFeedbackRadius(feedbackToShow, mScaleFactor) * 2.0f;
         if (diameter <= 0.0f) {
             return;
         }