Issue 2297013003: Fix problem occurring when an async* stream is paused at the end of a yield*.

Issue 2297013003: Fix problem occurring when an async* stream is paused at the end of a yield*. (Closed)

Created:
4 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
4 years, 3 months ago

Reviewers:
floitsch, siva, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, kustermann, floitsch

Target Ref:
refs/heads/master

Visibility:
Public.

Fix problem occurring when an async* stream is paused at the end of a yield*. In this case, the stream is unscheduled and it is not expecting to be resumed, so nothing further happens. Closes https://github.com/dart-lang/sdk/issues/27205 R=floitsch@google.com, hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/8a70e46d76924723138708c476c27ec11fa83cde

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -0 lines)			Patch
	M	runtime/lib/async_patch.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	tests/language/yieldstar_pause_test.dart	View		1 chunk	+44 lines, -0 lines	0 comments	Download

Total messages: 8 (4 generated)

hausner

LGTM It would be nice to add the explanation in this CL as a comment ...

4 years, 3 months ago (2016-08-31 15:52:56 UTC) #5

Lasse Reichstein Nielsen

4 years, 3 months ago (2016-09-01 09:03:40 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8a70e46d76924723138708c476c27ec11fa83cde (presubmit successful).