Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 22970004: Revert "Make GlobalHandle::NodeBlock deletable" (Closed)

Created:
7 years, 4 months ago by Jakob Kummerow
Modified:
7 years, 4 months ago
Reviewers:
danno
CC:
v8-dev, dcarney
Visibility:
Public.

Description

Revert "Make GlobalHandle::NodeBlock deletable" This reverts r16040 due to OOM crashes. R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -645 lines) Patch
M src/global-handles.h View 3 chunks +7 lines, -57 lines 0 comments Download
M src/global-handles.cc View 10 chunks +149 lines, -380 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +0 lines, -53 lines 0 comments Download
M test/cctest/test-global-handles.cc View 3 chunks +0 lines, -155 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +52 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
7 years, 4 months ago (2013-08-14 12:39:29 UTC) #1
danno
lgtm
7 years, 4 months ago (2013-08-14 12:40:24 UTC) #2
Jakob Kummerow
7 years, 4 months ago (2013-08-14 12:40:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16186.

Powered by Google App Engine
This is Rietveld 408576698