Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by Mircea Trofin Modified:
4 years, 3 months ago Reviewers:
bradnelson CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] mjsunit support for I32 globals and test
Test ensuring globals are isolated between instances. Also
added support for globals section to mjsunit's
WebModuleBuilder as a prerequisite.
BUG=
Committed: https://crrev.com/03f3da45e1c5768a6b28821b7ce395da7dc0bf4a
Cr-Commit-Position: refs/heads/master@{#39028}
Patch Set 1 #
Total comments: 4
Patch Set 2 : formatting #
Created: 4 years, 3 months ago
Messages
Total messages: 16 (10 generated)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [wasm] mjsunit support for I32 globals and test Test ensuring globals are isolated between instances. Also added support for globals section to mjsunit's WebModuleBuilder as a prerequisite. BUG= ========== to ========== [wasm] mjsunit support for I32 globals and test Test ensuring globals are isolated between instances. Also added support for globals section to mjsunit's WebModuleBuilder as a prerequisite. BUG= ==========
mtrofin@chromium.org changed reviewers: + bradnelson@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2296993002/diff/1/test/mjsunit/wasm/wasm-modu... File test/mjsunit/wasm/wasm-module-builder.js (right): https://codereview.chromium.org/2296993002/diff/1/test/mjsunit/wasm/wasm-modu... test/mjsunit/wasm/wasm-module-builder.js:206: section.emit_varint(0); //length of global name Formatting on this comment is odd. https://codereview.chromium.org/2296993002/diff/1/test/mjsunit/wasm/wasm-modu... test/mjsunit/wasm/wasm-module-builder.js:208: section.emit_u8(false); // we do not support exported globals These should be 2 spaces.
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bradnelson@chromium.org Link to the patchset: https://codereview.chromium.org/2296993002/#ps20001 (title: "formatting")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2296993002/diff/1/test/mjsunit/wasm/wasm-modu... File test/mjsunit/wasm/wasm-module-builder.js (right): https://codereview.chromium.org/2296993002/diff/1/test/mjsunit/wasm/wasm-modu... test/mjsunit/wasm/wasm-module-builder.js:206: section.emit_varint(0); //length of global name On 2016/08/30 23:36:20, bradnelson wrote: > Formatting on this comment is odd. Done. https://codereview.chromium.org/2296993002/diff/1/test/mjsunit/wasm/wasm-modu... test/mjsunit/wasm/wasm-module-builder.js:208: section.emit_u8(false); // we do not support exported globals On 2016/08/30 23:36:21, bradnelson wrote: > These should be 2 spaces. Done.
Message was sent while issue was closed.
Description was changed from ========== [wasm] mjsunit support for I32 globals and test Test ensuring globals are isolated between instances. Also added support for globals section to mjsunit's WebModuleBuilder as a prerequisite. BUG= ========== to ========== [wasm] mjsunit support for I32 globals and test Test ensuring globals are isolated between instances. Also added support for globals section to mjsunit's WebModuleBuilder as a prerequisite. BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [wasm] mjsunit support for I32 globals and test Test ensuring globals are isolated between instances. Also added support for globals section to mjsunit's WebModuleBuilder as a prerequisite. BUG= ========== to ========== [wasm] mjsunit support for I32 globals and test Test ensuring globals are isolated between instances. Also added support for globals section to mjsunit's WebModuleBuilder as a prerequisite. BUG= Committed: https://crrev.com/03f3da45e1c5768a6b28821b7ce395da7dc0bf4a Cr-Commit-Position: refs/heads/master@{#39028} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/03f3da45e1c5768a6b28821b7ce395da7dc0bf4a Cr-Commit-Position: refs/heads/master@{#39028} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
