[wasm] mjsunit support for I32 globals and test

[wasm] mjsunit support for I32 globals and test

Test ensuring globals are isolated between instances. Also
added support for globals section to mjsunit's
WebModuleBuilder as a prerequisite.

BUG=

Committed: https://crrev.com/03f3da45e1c5768a6b28821b7ce395da7dc0bf4a
Cr-Commit-Position: refs/heads/master@{#39028}

[Mircea Trofin, 2016-08-30 22:28:17]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 22:28:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2016-08-30 22:29:50]

Description was changed from

==========
[wasm] mjsunit support for I32 globals and test

Test ensuring globals are isolated between instances. Also added
support for globals section to mjsunit's WebModuleBuilder as a prerequisite.

BUG=
==========

to

==========
[wasm] mjsunit support for I32 globals and test

Test ensuring globals are isolated between instances. Also
added support for globals section to mjsunit's 
WebModuleBuilder as a prerequisite.

BUG=
==========

[Mircea Trofin, 2016-08-30 22:29:51]

mtrofin@chromium.org changed reviewers:
+ bradnelson@chromium.org

[commit-bot: I haz the power, 2016-08-30 22:51:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 22:51:16]

Dry run: This issue passed the CQ dry run.

[bradnelson, 2016-08-30 23:36:21]

lgtm

https://codereview.chromium.org/2296993002/diff/1/test/mjsunit/wasm/wasm-modu...
File test/mjsunit/wasm/wasm-module-builder.js (right):

https://codereview.chromium.org/2296993002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:206: section.emit_varint(0); //length
of global name
Formatting on this comment is odd.

https://codereview.chromium.org/2296993002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:208: section.emit_u8(false); // we do
not support exported globals
These should be 2 spaces.

[Mircea Trofin, 2016-08-31 00:08:00]

The CQ bit was checked by mtrofin@chromium.org

[Mircea Trofin, 2016-08-31 00:08:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/2296993002/#ps20001
(title: "formatting")

[commit-bot: I haz the power, 2016-08-31 00:08:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2016-08-31 00:08:15]

https://codereview.chromium.org/2296993002/diff/1/test/mjsunit/wasm/wasm-modu...
File test/mjsunit/wasm/wasm-module-builder.js (right):

https://codereview.chromium.org/2296993002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:206: section.emit_varint(0); //length
of global name
On 2016/08/30 23:36:20, bradnelson wrote:
> Formatting on this comment is odd.

Done.

https://codereview.chromium.org/2296993002/diff/1/test/mjsunit/wasm/wasm-modu...
test/mjsunit/wasm/wasm-module-builder.js:208: section.emit_u8(false); // we do
not support exported globals
On 2016/08/30 23:36:21, bradnelson wrote:
> These should be 2 spaces.

Done.

[commit-bot: I haz the power, 2016-08-31 00:35:52]

Description was changed from

==========
[wasm] mjsunit support for I32 globals and test

Test ensuring globals are isolated between instances. Also
added support for globals section to mjsunit's 
WebModuleBuilder as a prerequisite.

BUG=
==========

to

==========
[wasm] mjsunit support for I32 globals and test

Test ensuring globals are isolated between instances. Also
added support for globals section to mjsunit's 
WebModuleBuilder as a prerequisite.

BUG=
==========

[commit-bot: I haz the power, 2016-08-31 00:35:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-31 00:36:26]

Description was changed from

==========
[wasm] mjsunit support for I32 globals and test

Test ensuring globals are isolated between instances. Also
added support for globals section to mjsunit's 
WebModuleBuilder as a prerequisite.

BUG=
==========

to

==========
[wasm] mjsunit support for I32 globals and test

Test ensuring globals are isolated between instances. Also
added support for globals section to mjsunit's
WebModuleBuilder as a prerequisite.

BUG=

Committed: https://crrev.com/03f3da45e1c5768a6b28821b7ce395da7dc0bf4a
Cr-Commit-Position: refs/heads/master@{#39028}
==========

[commit-bot: I haz the power, 2016-08-31 00:36:27]

Patchset 2 (id:??) landed as
https://crrev.com/03f3da45e1c5768a6b28821b7ce395da7dc0bf4a
Cr-Commit-Position: refs/heads/master@{#39028}