Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js

Issue 2296983003: DevTools: kill WI.IsolatedFileSystemManager FileSystemsLoaded event (Closed)
Patch Set: remove nested arrow Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js b/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js
index 6aa4d3eec2f244c1cd4051488980b66caff8daca..399a348a934231c4eb5fa88750d4150db5e5c9f7 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js
@@ -17,24 +17,29 @@ WebInspector.NetworkMapping = function(targetManager, workspace, fileSystemWorks
this._fileSystemMapping = fileSystemMapping;
InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.RevealSourceLine, this._revealSourceLine, this);
- // For now, following block is here primarily for testing since in the real life, network manager is created early enough to capture those events.
var fileSystemManager = fileSystemWorkspaceBinding.fileSystemManager();
- for (var fileSystem of fileSystemManager.fileSystems())
- this._addMappingsForFilesystem(fileSystem);
- if (fileSystemManager.fileSystemsLoaded())
- this._fileSystemsLoaded();
-
this._eventListeners = [
fileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemAdded, this._fileSystemAdded, this),
fileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemRemoved, this._fileSystemRemoved, this),
- fileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemsLoaded, this._fileSystemsLoaded, this),
this._fileSystemMapping.addEventListener(WebInspector.FileSystemMapping.Events.FileMappingAdded, this._fileSystemMappingChanged, this),
this._fileSystemMapping.addEventListener(WebInspector.FileSystemMapping.Events.FileMappingRemoved, this._fileSystemMappingChanged, this)
];
+
+ fileSystemManager.waitForFileSystems()
+ .then(this._fileSystemsLoaded.bind(this));
}
WebInspector.NetworkMapping.prototype = {
/**
+ * @param {!Array<!WebInspector.IsolatedFileSystem>} fileSystems
+ */
+ _fileSystemsLoaded: function(fileSystems)
+ {
+ for (var fileSystem of fileSystems)
+ this._addMappingsForFilesystem(fileSystem);
+ },
+
+ /**
* @param {!WebInspector.Event} event
*/
_fileSystemAdded: function(event)
@@ -238,14 +243,9 @@ WebInspector.NetworkMapping.prototype = {
this._workspace.addEventListener(WebInspector.Workspace.Events.UISourceCodeAdded, listener, this);
},
- _fileSystemsLoaded: function()
- {
- this._fileSystemsReady = true;
- },
-
_fileSystemMappingChanged: function()
{
- if (!this._fileSystemsReady || this._addingFileSystem)
+ if (this._addingFileSystem)
return;
this._targetManager.suspendAndResumeAllTargets();
},

Powered by Google App Engine
This is Rietveld 408576698