Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2296983002: [HBD] Update MD Site Settings Plugin section to show Flash title (Closed)

Created:
4 years, 3 months ago by tommycli
Modified:
4 years, 3 months ago
Reviewers:
Finnur
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[HBD] Update MD Site Settings Plugin section to show Flash title Also updates the route from /siteSettings/plugins to /siteSettings/flash BUG=622922 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/17b65e3d5129b94fddfe3e9b3890805d1fd2ca44 Cr-Commit-Position: refs/heads/master@{#415650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/route.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_behavior.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
tommycli
finnur: PTAL, thanks!
4 years, 3 months ago (2016-08-30 22:31:19 UTC) #5
Finnur
LGTM
4 years, 3 months ago (2016-08-31 10:15:21 UTC) #8
tommycli
On 2016/08/31 10:15:21, Finnur wrote: > LGTM finnur: Thanks!
4 years, 3 months ago (2016-08-31 16:16:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296983002/1
4 years, 3 months ago (2016-08-31 16:17:10 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 16:21:10 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 16:24:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17b65e3d5129b94fddfe3e9b3890805d1fd2ca44
Cr-Commit-Position: refs/heads/master@{#415650}

Powered by Google App Engine
This is Rietveld 408576698