Moves ash content specific tests into ash_content_unittests

ash/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 import("//ui/base/ui_features.gni")
 
 assert(use_aura)
@@ skipping 166 matching lines @@
     "//ui/keyboard:keyboard_with_content",
     "//ui/resources",
     "//ui/strings",
     "//ui/views",
     "//ui/views/controls/webview",
     "//ui/web_dialogs",
     "//url",
   ]
 }
 
-# TODO(msw): Move support code with content deps to test_support_with_content.
-static_library("test_support") {
+# Internal target consumed by |test_support| and |test_support_with_content|.
+# This target contains all the test support files, with the exception of
+# an implementation of AshTestEnvironment. Consumers of ash should use one of
+# test_support_with_content or test_support, depending upon whether they use
+# content or use content.

[James Cook, 2016/08/31 16:20:16]

nit: use content or don't use content (or maybe not needed if targets renamed)

+static_library("test_support_no_environment") {

[James Cook, 2016/08/31 16:20:16]

nit: How about test_support_common or test_support_shared ?

[sky, 2016/08/31 17:35:57]

Good idea, renamed to test_support_shared.

   testonly = true
+  visibility = [ ":*" ]
   sources = gypi_values.ash_test_support_sources
   configs += [ "//build/config:precompiled_headers" ]
 
   public_deps = [
     ":ash",
   ]
   deps = [
-    ":test_support_with_content",  # TODO(beng): reverse this direction.
     "//ash/resources",
     "//base:i18n",
     "//base/test:test_support",
     "//components/signin/core/account_id",
     "//components/user_manager:user_manager",
-    "//content/public/browser",
-    "//content/test:test_support",
     "//device/bluetooth",
     "//skia",
     "//testing/gtest",
     "//ui/accessibility",
     "//ui/app_list:test_support",
     "//ui/app_list/presenter",
     "//ui/aura",
     "//ui/aura:test_support",
     "//ui/base:test_support",
     "//ui/compositor:test_support",
@@ skipping 19 matching lines @@
   }
 
   if (is_chromeos) {
     deps += [
       "//chromeos",
       "//ui/display",
     ]
   }
 }
 
+static_library("test_support") {

[James Cook, 2016/08/31 16:20:16]

nit: How about test_support_without_content ?

[sky, 2016/08/31 17:35:57]

Great idea! Done.

+  testonly = true
+  sources = [
+    "test/ash_test_environment_default.cc",
+  ]
+
+  public_deps = [
+    ":test_support_no_environment",
+  ]
+
+  deps = [
+    "//base",
+    "//skia",
+  ]
+}
+
 static_library("test_support_with_content") {
   testonly = true
   sources = gypi_values.ash_test_support_with_content_sources
+  sources += [
+    "test/ash_test_environment_content.cc",
+    "test/ash_test_environment_content.h",
+  ]
   configs += [ "//build/config:precompiled_headers" ]
 
-  deps = [
+  public_deps = [
     ":ash_with_content",
+    ":test_support_no_environment",
+    "//content/public/browser",
     "//content/test:test_support",
     "//skia",
   ]
 }
 
 static_library("interactive_ui_test_support") {
   testonly = true
   configs += [ "//build/config:precompiled_headers" ]
   public_deps = [
     ":ash",
     ":test_support",
   ]
   sources = [
     "test/ash_interactive_ui_test_base.cc",
     "test/ash_interactive_ui_test_base.h",
   ]
   deps = [
     ":ash",
-    ":test_support",
+    ":test_support_with_content",
     "//base",
     "//skia",
     "//testing/gtest",
     "//ui/aura",
     "//ui/base",
     "//ui/gl:test_support",
   ]
 }
 
 static_library("ash_shell_lib") {
@@ skipping 55 matching lines @@
     "//ui/message_center",
     "//ui/views:test_support",
     "//ui/wm",
   ]
 
   if (is_chromeos) {
     deps += [ "//chromeos" ]
   }
 }
 
-test("ash_unittests") {
-  sources = gypi_values.ash_unittests_sources
-  configs += [ "//build/config:precompiled_headers" ]
+test("ash_content_unittests") {

[James Cook, 2016/08/31 16:20:16]

nit: I would comment here about the content dependency, since this file is so
long that readers may not see the above comments.

[sky, 2016/08/31 17:35:57]

Done.

+  sources = [
+    "content/display/screen_orientation_controller_chromeos_unittest.cc",
+    "content/keyboard_overlay/keyboard_overlay_delegate_unittest.cc",
+    "content/keyboard_overlay/keyboard_overlay_view_unittest.cc",
+    "test/ash_unittests.cc",
+  ]
+  configs += [
+    "//build/config:precompiled_headers",
+    "//build/config/compiler:no_size_t_to_int_warning",
+  ]
 
   deps = [
     ":ash",
     ":ash_with_content",
-    ":test_support",
     ":test_support_with_content",
     "//ash/autoclick/common:autoclick",

[James Cook, 2016/08/31 16:20:16]

I suspect a lot of these deps are not required. Maybe make a quick pass and see
if a couple can be eliminated? (autoclick and touch_hud seem like obvious
candidates).

This might be helpful:
cd ash/content
find . -name *test* | xargs grep include | cut --fields 2 --delimiter=" " | sort
| uniq

[sky, 2016/08/31 17:35:57]

Indeed. I just copied the list from ash_unittests. I've pruned it.

     "//ash/common/strings",
     "//ash/resources",
     "//ash/touch_hud",
     "//base",
     "//base/test:test_support",
     "//components/signin/core/account_id",
     "//components/user_manager",
     "//content/public/browser",
     "//content/test:test_support",
     "//mojo/edk/system",
     "//skia",
+    "//testing/gmock",
     "//testing/gtest",
     "//third_party/icu",
     "//ui/accessibility",
     "//ui/app_list/presenter",
     "//ui/aura",
     "//ui/aura:test_support",
     "//ui/base",
     "//ui/base:test_support",
     "//ui/base/ime",
     "//ui/compositor",
@@ skipping 19 matching lines @@
     "//ui/wm:test_support",
     "//url",
   ]
 
   data_deps = [
     "//ash/common/strings:ash_test_strings",
     "//ash/resources:ash_test_resources_100_percent",
     "//ash/resources:ash_test_resources_200_percent",
   ]
 
-  if (!is_chromeos) {
-    sources -= [
-      # TODO(zork): fix this test to build on Windows. See: crosbug.com/26906
-      "focus_cycler_unittest.cc",
-
-      # All tests for multiple displays: not supported on Windows Ash.
-      "wm/drag_window_resizer_unittest.cc",
-
-      # Talks to ChromeOS system services.
-      "wm/lock_state_controller_unittest.cc",
-
-      # Maximize mode is only available on Chrome OS.
-      "wm/maximize_mode/maximize_mode_controller_unittest.cc",
-      "wm/maximize_mode/maximize_mode_window_manager_unittest.cc",
-
-      # Can't resize on Windows Ash. http://crbug.com/165962
-      "autoclick/autoclick_unittest.cc",
-      "magnifier/magnification_controller_unittest.cc",
-      "magnifier/partial_magnification_controller_unittest.cc",
-      "sticky_keys/sticky_keys_overlay_unittest.cc",
-      "virtual_keyboard_controller_unittest.cc",
-      "wm/workspace/workspace_window_resizer_unittest.cc",
+  if (is_chromeos) {
+    deps += [
+      "//chromeos",
+      "//chromeos:power_manager_proto",
+      "//chromeos:test_support_without_gmock",
+      "//components/quirks",
+      "//device/bluetooth",
+      "//net:net",
+      "//ui/chromeos",
+      "//ui/display",
+      "//ui/display:test_support",
+      "//ui/display:test_util",
     ]
   }
+}
 
-  configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+test("ash_unittests") {
+  sources = gypi_values.ash_unittests_sources
+  sources += [ "test/ash_test_environment_default.cc" ]
+  configs += [
+    "//build/config:precompiled_headers",
+    "//build/config/compiler:no_size_t_to_int_warning",
+  ]
+
+  deps = [
+    ":ash",
+    ":test_support",
+    "//ash/autoclick/common:autoclick",
+    "//ash/common/strings",
+    "//ash/resources",
+    "//ash/touch_hud",
+    "//base",
+    "//base/test:test_support",
+    "//components/signin/core/account_id",
+    "//components/user_manager",
+    "//mojo/edk/system",
+    "//skia",
+    "//testing/gmock",
+    "//testing/gtest",
+    "//third_party/icu",
+    "//ui/accessibility",
+    "//ui/app_list/presenter",
+    "//ui/aura",
+    "//ui/aura:test_support",
+    "//ui/base",
+    "//ui/base:test_support",
+    "//ui/base/ime",
+    "//ui/compositor",
+    "//ui/compositor:test_support",
+    "//ui/display/types",
+    "//ui/events",
+    "//ui/events:gesture_detection",
+    "//ui/events:test_support",
+    "//ui/events/devices",
+    "//ui/gfx",
+    "//ui/gfx/geometry",
+    "//ui/keyboard",
+    "//ui/message_center",
+    "//ui/message_center:test_support",
+    "//ui/resources",
+    "//ui/strings",
+    "//ui/views",
+    "//ui/views:test_support",
+    "//ui/wm",
+    "//ui/wm:test_support",
+    "//url",
+  ]
+
+  data_deps = [
+    "//ash/common/strings:ash_test_strings",
+    "//ash/resources:ash_test_resources_100_percent",
+    "//ash/resources:ash_test_resources_200_percent",
+  ]
 
   if (!use_x11) {
     sources -= [ "host/ash_window_tree_host_x11_unittest.cc" ]
   }
+
   if (is_chromeos) {
     sources += [ "first_run/first_run_helper_unittest.cc" ]
     deps += [
       "//chromeos",
       "//chromeos:power_manager_proto",
       "//chromeos:test_support_without_gmock",
       "//components/quirks",
       "//device/bluetooth",
       "//net:net",
       "//ui/chromeos",
       "//ui/display",
       "//ui/display:test_support",
       "//ui/display:test_util",
     ]
   } else {
     sources -= [
       "accelerators/magnifier_key_scroller_unittest.cc",
       "accelerators/spoken_feedback_toggler_unittest.cc",
+
+      # Can't resize on Windows Ash. http://crbug.com/165962
+      "autoclick/autoclick_unittest.cc",
       "display/resolution_notification_controller_unittest.cc",
+
+      # TODO(zork): fix this test to build on Windows. See: crosbug.com/26906
+      "focus_cycler_unittest.cc",
+      "magnifier/magnification_controller_unittest.cc",
+      "magnifier/partial_magnification_controller_unittest.cc",
+      "sticky_keys/sticky_keys_overlay_unittest.cc",
+      "sticky_keys/sticky_keys_unittest.cc",
       "touch/touchscreen_util_unittest.cc",
+      "virtual_keyboard_controller_unittest.cc",
+
+      # All tests for multiple displays: not supported on Windows Ash.
+      "wm/drag_window_resizer_unittest.cc",
+
+      # Talks to ChromeOS system services.
+      "wm/lock_state_controller_unittest.cc",
+
+      # Maximize mode is only available on Chrome OS.
+      "wm/maximize_mode/maximize_mode_controller_unittest.cc",
+      "wm/maximize_mode/maximize_mode_window_manager_unittest.cc",
+      "wm/workspace/workspace_window_resizer_unittest.cc",
     ]
   }
 
   if (!use_x11 || !is_chromeos) {
     sources -= [ "touch/touch_transformer_controller_unittest.cc" ]
   }
-
-  if (!is_chromeos) {
-    sources -= [ "sticky_keys/sticky_keys_unittest.cc" ]
-  }
 }
 
 executable("ash_shell_with_content") {
   testonly = true
   sources = [
     "shell/content/shell_with_content_main.cc",
   ]
 
   deps = [
     ":ash_shell_lib_with_content",
@@ skipping 16 matching lines @@
     configs += [ "//build/config/win:windowed" ]
     deps += [ "//sandbox" ]
   }
 
   if (is_chromeos) {
     deps += [ "//device/bluetooth" ]
   }
 }
 # When adding support for isolates, please have a look at run-time dependencies
 # in the ash_unittests_run target in ash.gyp.