Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2296953008: Restore missing compile_js*.gypi. (Closed)

Created:
4 years, 3 months ago by fukino
Modified:
4 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore missing compile_js*.gypi. third_party/closure_compiler/run_compiler was failing due to missing compile_js*.gypi under ui/file_manager. BUG=none TEST=third_party/closue_compiler/run_compiler TBR=dbeam@chromium.org Committed: https://crrev.com/16fc14e15651f4e375624fa5e82a8b5a6e8a294b Cr-Commit-Position: refs/heads/master@{#416263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
A + ui/file_manager/compile_js.gypi View 1 chunk +5 lines, -5 lines 0 comments Download
A ui/file_manager/compile_js2.gypi View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
fukino
TBRing Dan to get the closure bot recovered earlier.
4 years, 3 months ago (2016-09-02 13:50:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296953008/1
4 years, 3 months ago (2016-09-02 13:50:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 14:36:09 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/16fc14e15651f4e375624fa5e82a8b5a6e8a294b Cr-Commit-Position: refs/heads/master@{#416263}
4 years, 3 months ago (2016-09-02 14:39:33 UTC) #9
Dan Beam
4 years, 3 months ago (2016-09-02 21:48:13 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698