Send certificates to devtools when it's open instead of using certId

third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h

Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
index c5237f32a7face254e41c5571db37f9ae216350a..9349fe222d2b23ca8284354c4722b4626218efdd 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.h
@@ -38,6 +38,7 @@
 #include "core/inspector/protocol/Network.h"
 #include "platform/Timer.h"
 #include "platform/heap/Handle.h"
+#include "wtf/text/AtomicString.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
@@ -68,9 +69,16 @@ class DictionaryValue;
 
 class CORE_EXPORT InspectorNetworkAgent final : public InspectorBaseAgent<protocol::Network::Metainfo> {
 public:
-    static InspectorNetworkAgent* create(InspectedFrames* inspectedFrames)
+    class Client {
+    public:
+        virtual ~Client() { }
+
+        virtual void showCertificateViewer(const AtomicString& certificate) = 0;
+    };
+
+    static InspectorNetworkAgent* create(Client* client, InspectedFrames* inspectedFrames)
     {
-        return new InspectorNetworkAgent(inspectedFrames);
+        return new InspectorNetworkAgent(client, inspectedFrames);
     }
 
     void restore() override;
@@ -146,13 +154,14 @@ public:
     void setCacheDisabled(ErrorString*, bool cacheDisabled) override;
     void setBypassServiceWorker(ErrorString*, bool bypass) override;
     void setDataSizeLimitsForTest(ErrorString*, int maxTotalSize, int maxResourceSize) override;
+    void showCertificateViewer(ErrorString*, int certificateHash) override;
 
     // Called from other agents.
     void setHostId(const String&);
     bool fetchResourceContent(Document*, const KURL&, String* content, bool* base64Encoded);
 
 private:
-    explicit InspectorNetworkAgent(InspectedFrames*);
+    InspectorNetworkAgent(Client*, InspectedFrames*);
 
     void enable(int totalBufferSize, int resourceBufferSize);
     void willSendRequestInternal(LocalFrame*, unsigned long identifier, DocumentLoader*, const ResourceRequest&, const ResourceResponse& redirectResponse, const FetchInitiatorInfo&);
@@ -164,6 +173,7 @@ private:
     void getResponseBodyBlob(const String& requestId, std::unique_ptr<GetResponseBodyCallback>);
     void clearPendingRequestData();
 
+    Client* m_client;
     Member<InspectedFrames> m_inspectedFrames;
     String m_userAgentOverride;
     String m_hostId;
@@ -187,6 +197,10 @@ private:
     std::unique_ptr<protocol::Network::Initiator> m_styleRecalculationInitiator;
     bool m_isRecalculatingStyle;
 
+    // Optimization so that we don't send the full cerfificate data to the frontend.

[jam, 2016/08/31 22:13:28]

this hash map isn't for saving memory (since I'm using AtomicString), but so
that we have a small id (the string's hash) that we can send to the devtools
front end instead of the entire certificate

+    typedef HashMap<unsigned, AtomicString> CertificateHashMap;
+    CertificateHashMap m_certificateHashMap;

[pfeldman, 2016/08/31 23:08:45]

We should clean it up at least from InspectorNetworkAgent::disable.

In fact, it should be cleaned up in InspectorNetworkAgent::didCommitLoad (except
for that one is after main resource cert has been added into the map, so simple
code won't work there).

Could you instead add certificate data into the NetworkResourcesData
per-resource and then use request id to refer to the certificate? You would not
need a map then and the cert lifetime would be auto-managed.

[jam, 2016/08/31 23:15:09]

Done
I'm not sure I understand this comment. Why would we want to delete the
certificate information after a resource commits? We'd need the certificate
after it commits in case the user chooses to view the certificate for that
origin?
That was my initial attempt. However it was awkward because SecurityOrigin
stores this data in a map (_origins) which is keyed by origin and the values are
securitydetails. it seemed odd to put the request id in the origin's value?

+
     HeapHashSet<Member<XMLHttpRequest>> m_replayXHRs;
     HeapHashSet<Member<XMLHttpRequest>> m_replayXHRsToBeDeleted;
     Timer<InspectorNetworkAgent> m_removeFinishedReplayXHRTimer;