Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: third_party/WebKit/Source/platform/exported/WebURLResponse.cpp

Issue 2296953004: Send certificates to devtools when it's open instead of using certId (Closed)
Patch Set: self review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
diff --git a/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp b/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
index 09de4f04a11ac699fe28286b1012898de246acbf..509143e2e5ac663c32f781d8de7656220d53edd4 100644
--- a/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
+++ b/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
@@ -335,12 +335,24 @@ void WebURLResponse::setSecurityDetails(const WebSecurityDetails& webSecurityDet
blink::ResourceResponse::SignedCertificateTimestampList sctList;
for (const auto& iter : webSecurityDetails.sctList)
sctList.append(static_cast<blink::ResourceResponse::SignedCertificateTimestamp>(iter));
+ Vector<String> sanList;
+ sanList.append(webSecurityDetails.sanList.data(), webSecurityDetails.sanList.size());
+ Vector<AtomicString> certificate;
+ for (const auto& iter : webSecurityDetails.certificate) {
+ AtomicString cert = iter;
+ certificate.append(cert);
+ }
m_resourceResponse->setSecurityDetails(
webSecurityDetails.protocol,
webSecurityDetails.keyExchange,
webSecurityDetails.cipher,
webSecurityDetails.mac,
- webSecurityDetails.certId,
+ webSecurityDetails.subjectName,
+ sanList,
+ webSecurityDetails.issuer,
+ static_cast<time_t>(webSecurityDetails.validFrom),
+ static_cast<time_t>(webSecurityDetails.validTo),
+ certificate,
sctList);
}

Powered by Google App Engine
This is Rietveld 408576698