Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2296953004: Send certificates to devtools when it's open instead of using certId (Closed)
Patch Set: self review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/browser_protocol.json
diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json
index 1c0174bb324bd5d29efa66124ca230c60496ff86..dd813e5a5942a4bee11c19431374ce96ea148dbe 100644
--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json
+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json
@@ -890,6 +890,14 @@
"name": "disable",
"description": "Disables tracking security state changes.",
"handlers": ["browser"]
+ },
+ {
+ "name": "showCertificateViewer",
+ "description": "Displays native dialog with the certificate details.",
+ "parameters": [
+ { "name": "certificateId", "$ref": "Security.CertificateId", "description": "Certificate id." }
+ ],
+ "handlers": ["browser"]
}
],
"events": [
@@ -986,27 +994,6 @@
]
},
{
- "id": "CertificateSubject",
- "type": "object",
- "description": "Subject of a certificate.",
- "properties": [
- { "name": "name", "type": "string", "description": "Certificate subject name." },
- { "name": "sanDnsNames", "type": "array", "items": { "type": "string" }, "description": "Subject Alternative Name (SAN) DNS names." },
- { "name": "sanIpAddresses", "type": "array", "items": { "type": "string" }, "description": "Subject Alternative Name (SAN) IP addresses." }
- ]
- },
- {
- "id": "CertificateDetails",
- "type": "object",
- "description": "Details about a request's certificate.",
- "properties": [
- { "name": "subject", "$ref": "CertificateSubject", "description": "Certificate subject." },
- { "name": "issuer", "type": "string", "description": "Name of the issuing CA." },
- { "name": "validFrom", "$ref": "Timestamp", "description": "Certificate valid from date." },
- { "name": "validTo", "$ref": "Timestamp", "description": "Certificate valid to (expiration) date" }
- ]
- },
- {
"id": "SignedCertificateTimestamp",
"type" : "object",
"description": "Details of a signed certificate timestamp (SCT).",
@@ -1031,6 +1018,11 @@
{ "name": "cipher", "type": "string", "description": "Cipher name." },
{ "name": "mac", "type": "string", "optional": true, "description": "TLS MAC. Note that AEAD ciphers do not have separate MACs." },
{ "name": "certificateId", "$ref": "Security.CertificateId", "description": "Certificate ID value." },
+ { "name": "subjectName", "type": "string", "description": "Certificate subject name." },
+ { "name": "sanList", "type": "array", "items": { "type": "string" }, "description": "Subject Alternative Name (SAN) DNS names and IP addresses." },
+ { "name": "issuer", "type": "string", "description": "Name of the issuing CA." },
+ { "name": "validFrom", "$ref": "Timestamp", "description": "Certificate valid from date." },
+ { "name": "validTo", "$ref": "Timestamp", "description": "Certificate valid to (expiration) date" },
{ "name": "signedCertificateTimestampList", "type": "array", "items": { "$ref": "SignedCertificateTimestamp" }, "description": "List of signed certificate timestamps (SCTs)." }
]
},
@@ -1325,23 +1317,16 @@
"experimental": true
},
{
- "name": "getCertificateDetails",
- "description": "Returns details for the given certificate.",
+ "name": "getCertificate",
+ "description": "Returns the DER-encoded certificate.",
"parameters": [
- { "name": "certificateId", "$ref": "Security.CertificateId", "description": "ID of the certificate to get details for." }
+ { "name": "origin", "type": "string", "description": "Origin to get certificate for." }
],
"returns": [
- { "name": "result", "$ref": "CertificateDetails", "description": "Certificate details." }
- ],
- "handlers": ["browser"]
- },
- {
- "name": "showCertificateViewer",
- "description": "Displays native dialog with the certificate details.",
- "parameters": [
- { "name": "certificateId", "$ref": "Security.CertificateId", "description": "Certificate id." }
+ { "name": "tableNames", "type": "array", "items": { "type": "string" } }
],
- "handlers": ["browser"]
+ "handlers": ["renderer"],
+ "experimental": true
}
],
"events": [

Powered by Google App Engine
This is Rietveld 408576698