Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: content/browser/devtools/protocol/network_handler.cc

Issue 2296953004: Send certificates to devtools when it's open instead of using certId (Closed)
Patch Set: pfeldman comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/network_handler.cc
diff --git a/content/browser/devtools/protocol/network_handler.cc b/content/browser/devtools/protocol/network_handler.cc
index 4029b4b3d3cd0e6cff7aa59d9a3ac6c3dd71d7ef..d3da62c536bd0fdc37951ea5809202acc075404c 100644
--- a/content/browser/devtools/protocol/network_handler.cc
+++ b/content/browser/devtools/protocol/network_handler.cc
@@ -424,43 +424,6 @@ Response NetworkHandler::EmulateNetworkConditions(
return Response::FallThrough();
}
-Response NetworkHandler::GetCertificateDetails(
- int certificate_id,
- scoped_refptr<CertificateDetails>* result) {
- scoped_refptr<net::X509Certificate> cert;
- content::CertStore* cert_store = CertStore::GetInstance();
- cert_store->RetrieveCert(certificate_id, &cert);
- if (!cert.get())
- return Response::InvalidParams("certificateId");
-
- std::string name(cert->subject().GetDisplayName());
- std::string issuer(cert->issuer().GetDisplayName());
- base::Time valid_from = cert->valid_start();
- base::Time valid_to = cert->valid_expiry();
-
- std::vector<std::string> dns_names;
- std::vector<std::string> ip_addrs;
- cert->GetSubjectAltName(&dns_names, &ip_addrs);
-
- // IP addresses are in raw network bytes and must be converted to string form
- std::vector<std::string> ip_addrs_string;
- for (const std::string& ip : ip_addrs) {
- net::IPAddress ip_addr(reinterpret_cast<const uint8_t*>(ip.c_str()),
- ip.length());
- ip_addrs_string.push_back(ip_addr.ToString());
- }
-
- *result = CertificateDetails::Create()
- ->set_subject(CertificateSubject::Create()
- ->set_name(name)
- ->set_san_dns_names(dns_names)
- ->set_san_ip_addresses(ip_addrs_string))
- ->set_issuer(issuer)
- ->set_valid_from(valid_from.ToDoubleT())
- ->set_valid_to(valid_to.ToDoubleT());
- return Response::OK();
-}
-
Response NetworkHandler::ShowCertificateViewer(int certificate_id) {
if (!host_)
return Response::InternalError("Could not connect to view");

Powered by Google App Engine
This is Rietveld 408576698