Send certificates to devtools when it's open instead of using certId

chrome/browser/devtools/devtools_ui_bindings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/devtools_ui_bindings.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 663 matching lines @@
                                           file_system_path));
 }
 
 void DevToolsUIBindings::SetWhitelistedShortcuts(const std::string& message) {
   delegate_->SetWhitelistedShortcuts(message);
 }
 
 void DevToolsUIBindings::ShowCertificateViewer(const std::string& cert_chain) {
   std::unique_ptr<base::Value> value =
       base::JSONReader::Read(cert_chain);
-  if (!value || value->GetType() != base::Value::TYPE_LIST)
+  if (!value || value->GetType() != base::Value::TYPE_LIST) {
+    NOTREACHED();
     return;
+  }
 
   std::unique_ptr<base::ListValue> list =
       base::ListValue::From(std::move(value));
-  std::vector<base::StringPiece> cert_string_piece;
+  std::vector<std::string> decoded;
   for (size_t i = 0; i < list->GetSize(); ++i) {
     base::Value* item;
-    if (!list->Get(i, &item) || item->GetType() != base::Value::TYPE_STRING)
+    if (!list->Get(i, &item) || item->GetType() != base::Value::TYPE_STRING) {
+      NOTREACHED();
       return;
-    cert_string_piece.push_back(
-        *static_cast<base::StringValue*>(item)->GetString());
+    }
+    std::string temp;
+    if (!item->GetAsString(&temp)) {
+      NOTREACHED();
+      return;
+    }
+    if (!base::Base64Decode(temp, &temp)) {
+      NOTREACHED();
+      return;
+    }
+    decoded.push_back(temp);
   }
+
+  std::vector<base::StringPiece> cert_string_piece;
+  for (const auto& str : decoded)
+    cert_string_piece.push_back(str);
   scoped_refptr<net::X509Certificate> cert =
        net::X509Certificate::CreateFromDERCertChain(cert_string_piece);
-  if (!cert)
+  if (!cert) {
+    NOTREACHED();
     return;
+  }
 
   // TODO(jam): temporarily add the certificate to the cert store to get an ID
   // so that we don't have to change the WCD method signature
   // (will be done in followups).
   if (!agent_host_ || !agent_host_->GetWebContents())
     return;
   content::WebContents* inspected_wc = agent_host_->GetWebContents();
   content::RenderProcessHost* rph = inspected_wc->GetRenderProcessHost();
   int cert_id = content::CertStore::GetInstance()->StoreCert(
       cert.get(), rph->GetID());
   web_contents_->GetDelegate()->ShowCertificateViewerInDevTools(
-      web_contents_, cert_id);
+      inspected_wc, cert_id);
 }
 
 void DevToolsUIBindings::ZoomIn() {
   zoom::PageZoom::Zoom(web_contents(), content::PAGE_ZOOM_IN);
 }
 
 void DevToolsUIBindings::ZoomOut() {
   zoom::PageZoom::Zoom(web_contents(), content::PAGE_ZOOM_OUT);
 }
 
@@ skipping 413 matching lines @@
 void DevToolsUIBindings::FrontendLoaded() {
   if (frontend_loaded_)
     return;
   frontend_loaded_ = true;
 
   // Call delegate first - it seeds importants bit of information.
   delegate_->OnLoadCompleted();
 
   AddDevToolsExtensionsToClient();
 }