Send certificates to devtools when it's open instead of using certId

content/renderer/devtools/devtools_agent.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/devtools/devtools_agent.h"
 
 #include <stddef.h>
 
 #include <map>
 
@@ skipping 17 matching lines @@
 #include "third_party/WebKit/public/platform/WebPoint.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/web/WebDevToolsAgent.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 
 using blink::WebDevToolsAgent;
 using blink::WebDevToolsAgentClient;
 using blink::WebLocalFrame;
 using blink::WebPoint;
 using blink::WebString;
+using blink::WebVector;
 
 using base::trace_event::TraceLog;
 
 namespace content {
 
 namespace {
 
 const size_t kMaxMessageChunkSize = IPC::Channel::kMaximumMessageSize / 4;
 const char kPageGetAppManifest[] = "Page.getAppManifest";
 
@@ skipping 143 matching lines @@
 }
 
 void DevToolsAgent::disableTracing() {
   TraceLog::GetInstance()->SetDisabled();
 }
 
 void DevToolsAgent::setCPUThrottlingRate(double rate) {
   cpu_throttler_->SetThrottlingRate(rate);
 }
 
+void DevToolsAgent::showCertificateViewer(
+    const WebVector<WebString>& certificate) {
+  std::vector<std::string> cert_vector;
+  for (auto cert : certificate)

[Ryan Sleevi, 2016/09/03 00:02:51]

STYLE nit: const auto& ? Do you really intend to be making a copy each time?

(Per the guidance on https://chromium-cpp.appspot.com/ regarding range-based for
loops)

[jam, 2016/09/03 01:42:39]

That was an oversight, but now that code is gone after Pavel's change

+    cert_vector.push_back(cert.latin1());
+  Send(new DevToolsAgentHostMsg_ShowCertificateViewer(
+      routing_id(), cert_vector));
+}
+
 // static
 DevToolsAgent* DevToolsAgent::FromRoutingId(int routing_id) {
   IdToAgentMap::iterator it = g_agent_for_routing_id.Get().find(routing_id);
   if (it != g_agent_for_routing_id.Get().end()) {
     return it->second;
   }
   return NULL;
 }
 
 // static
@@ skipping 133 matching lines @@
   result->Set("errors", errors.release());
   response->Set("result", result.release());
 
   std::string json_message;
   base::JSONWriter::Write(*response, &json_message);
   SendChunkedProtocolMessage(this, routing_id(), session_id, call_id,
                              json_message, std::string());
 }
 
 }  // namespace content