Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2296923002: Delete ResourceLoaderSet (Closed)

Created:
4 years, 3 months ago by Nate Chapin
Modified:
4 years, 3 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete ResourceLoaderSet It's a fairly thin wrapper on a HeapHashSet, and the two non-trivial functions are each only called from a single place in ResourceFetcher. Inline them there. BUG= Committed: https://crrev.com/69e5daff21ce62e87a0b58a7964104dd341d6df3 Cr-Commit-Position: refs/heads/master@{#415667}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -137 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 3 chunks +14 lines, -5 lines 1 comment Download
D third_party/WebKit/Source/core/fetch/ResourceLoaderSet.h View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/Source/core/fetch/ResourceLoaderSet.cpp View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Nate Chapin
WDYT? https://codereview.chromium.org/2296923002/diff/1/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/2296923002/diff/1/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp#newcode1079 third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:1079: loader->setDefersLoading(defers); I don't think copying the loaders to ...
4 years, 3 months ago (2016-08-30 22:38:31 UTC) #6
Mike West
Makes sense to me. LGTM.
4 years, 3 months ago (2016-08-31 13:15:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296923002/1
4 years, 3 months ago (2016-08-31 17:15:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 17:19:00 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 17:21:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69e5daff21ce62e87a0b58a7964104dd341d6df3
Cr-Commit-Position: refs/heads/master@{#415667}

Powered by Google App Engine
This is Rietveld 408576698