Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2296903003: Long options should not break the layout of chrome://flags (Closed)

Created:
4 years, 3 months ago by wychen
Modified:
4 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Long options should not break the layout of chrome://flags BUG=642599 Committed: https://crrev.com/4d9b4a7e2b0f6eb22635eb820dd54c7acbddafd1 Cr-Commit-Position: refs/heads/master@{#415730}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M components/flags_ui/resources/flags.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
wychen
PTAL
4 years, 3 months ago (2016-08-31 02:16:11 UTC) #2
Dan Beam
lgtm
4 years, 3 months ago (2016-08-31 18:42:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296903003/1
4 years, 3 months ago (2016-08-31 18:53:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 20:03:35 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 20:05:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d9b4a7e2b0f6eb22635eb820dd54c7acbddafd1
Cr-Commit-Position: refs/heads/master@{#415730}

Powered by Google App Engine
This is Rietveld 408576698