Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 2296903002: [Mac] Fullscreen Toolbar Edge Cases (Closed)
Patch Set: nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h » ('j') | chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index 7e6e3eeb9ed99521fc3333c559544e57fdf36d60..ad9c4838ea7898ecd32ec145aa7b6719703dd9bb 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -852,9 +852,9 @@ willPositionSheet:(NSWindow*)sheet
barVisibilityUpdatesEnabled_ = YES;
if ([barVisibilityLocks_ count])
- [fullscreenToolbarController_ ensureOverlayShownWithAnimation:NO];
+ [fullscreenToolbarController_ showToolbarIfPossibleWithAnimation:NO];
else
- [fullscreenToolbarController_ ensureOverlayHiddenWithAnimation:NO];
+ [fullscreenToolbarController_ hideToolbarIfPossibleWithAnimation:NO];
}
- (void)disableBarVisibilityUpdates {
@@ -870,7 +870,7 @@ willPositionSheet:(NSWindow*)sheet
if (!barVisibilityUpdatesEnabled_ || [barVisibilityLocks_ count])
return;
- [fullscreenToolbarController_ ensureOverlayHiddenWithAnimation:animation];
+ [fullscreenToolbarController_ hideToolbarIfPossibleWithAnimation:animation];
}
- (CGFloat)toolbarDividerOpacity {
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h » ('j') | chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698