Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2296863005: Inline chrome/browser sources in GN build. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inline chrome/browser sources in GN build. Remove chrome_browser.gypi TBR=dpranke@chromium.org Committed: https://crrev.com/ffdd85c2e101adf2bd9253f8e7f21fe001e37bdd Cr-Commit-Position: refs/heads/master@{#415789}

Patch Set 1 #

Patch Set 2 : Android paths #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2012 lines, -3353 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 18 chunks +2012 lines, -170 lines 0 comments Download
D chrome/chrome_browser.gypi View 1 chunk +0 lines, -3182 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
brettw
4 years, 3 months ago (2016-08-31 20:11:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296863005/1
4 years, 3 months ago (2016-08-31 20:12:29 UTC) #3
brettw
Android paths
4 years, 3 months ago (2016-08-31 20:36:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296863005/20001
4 years, 3 months ago (2016-08-31 20:36:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/272445)
4 years, 3 months ago (2016-08-31 21:30:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296863005/20001
4 years, 3 months ago (2016-08-31 21:39:24 UTC) #10
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-31 22:40:08 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 22:42:03 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 22:44:48 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ffdd85c2e101adf2bd9253f8e7f21fe001e37bdd
Cr-Commit-Position: refs/heads/master@{#415789}

Powered by Google App Engine
This is Rietveld 408576698