Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2296863004:
Shrink the minimum height of the message center (Closed)
DescriptionShrink the minimum height of the message center
New minimum height (77 dip) is matched for a single custom notification.
BUG=642804
Committed: https://crrev.com/e6dd1743c29c07fbbeee960f9d28f7960ab107b6
Cr-Commit-Position: refs/heads/master@{#417473}
Patch Set 1 #Patch Set 2 : Removed debug output #
Total comments: 1
Messages
Total messages: 18 (13 generated)
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run
Description was changed from ========== . BUG= ========== to ========== Shrink the minimum height of the message center New minimum height (77 dip) is matched for a single custom notification. BUG=642804 ==========
yoshiki@chromium.org changed reviewers: + dewittj@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Justin, PTAL. Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2296863004/diff/20001/ui/message_center/messa... File ui/message_center/message_center_style.h (right): https://codereview.chromium.org/2296863004/diff/20001/ui/message_center/messa... ui/message_center/message_center_style.h:35: const int kMinScrollViewHeight = 77; nit: please mention where this height came from, 77 seems very arbitrary :)
The CQ bit was checked by yoshiki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Shrink the minimum height of the message center New minimum height (77 dip) is matched for a single custom notification. BUG=642804 ========== to ========== Shrink the minimum height of the message center New minimum height (77 dip) is matched for a single custom notification. BUG=642804 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Shrink the minimum height of the message center New minimum height (77 dip) is matched for a single custom notification. BUG=642804 ========== to ========== Shrink the minimum height of the message center New minimum height (77 dip) is matched for a single custom notification. BUG=642804 Committed: https://crrev.com/e6dd1743c29c07fbbeee960f9d28f7960ab107b6 Cr-Commit-Position: refs/heads/master@{#417473} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e6dd1743c29c07fbbeee960f9d28f7960ab107b6 Cr-Commit-Position: refs/heads/master@{#417473} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
