Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Issue 2296863003: Update PositionTemplate::toAnchorTypeAndOffsetString(). (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update PositionTemplate::toAnchorTypeAndOffsetString(). - Use symbols consistent with operator<< for PositionAnchorType. - Add offset only if OffsetInAnchor The output of PositionTemplate::showTreeForThis() is changed: BODY * #text ... offset, offset:9 to BODY * #text ... offsetInAnchor[9] - printPosition() uses toAnchorTypeAndOffsetString(). The output of printPosition for OffsetInAnchor is changed: #text "..."@9 to #text "..."@offsetInAnchor[9] This CL doesn't affect production. Committed: https://crrev.com/3865439c6ff3795aaee47d9452a3f78aa6c1f202 Cr-Commit-Position: refs/heads/master@{#415604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M third_party/WebKit/Source/core/editing/Position.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 2 chunks +16 lines, -21 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
tkent
yosin@, would you review this please?
4 years, 3 months ago (2016-08-31 06:36:12 UTC) #15
yosin_UTC9
lgtm
4 years, 3 months ago (2016-08-31 06:54:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296863003/40001
4 years, 3 months ago (2016-08-31 07:53:39 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 3 months ago (2016-08-31 10:51:45 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 10:53:11 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3865439c6ff3795aaee47d9452a3f78aa6c1f202
Cr-Commit-Position: refs/heads/master@{#415604}

Powered by Google App Engine
This is Rietveld 408576698