Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2296843002: SkFontMgr_FontConfigInterface create typeface from FontParameters. (Closed)

Created:
4 years, 3 months ago by bungeman-skia
Modified:
4 years, 3 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkFontMgr_FontConfigInterface create typeface from FontParameters. This implements SkFontMgr_FontConfigInterface::onCreateFromStream(SkStreamAsset*, const FontParameters&) and makes the changes needed to support it. This will allow Chromium to create variation fonts from data. BUG=skia:5697 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2296843002 Committed: https://skia.googlesource.com/skia/+/4bb029cd9f7c00ac146df1f4c66d1ac5c078b78b

Patch Set 1 #

Patch Set 2 : Consistent order, remove unwanted change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -25 lines) Patch
M src/ports/SkFontConfigTypeface.h View 3 chunks +14 lines, -19 lines 0 comments Download
M src/ports/SkFontMgr_FontConfigInterface.cpp View 1 2 chunks +53 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
bungeman-skia
4 years, 3 months ago (2016-08-30 17:24:34 UTC) #6
bungeman-skia
4 years, 3 months ago (2016-08-30 18:22:45 UTC) #10
drott
Hooray, awesome - let me get to trying this on Linux. Thank you!
4 years, 3 months ago (2016-08-31 08:21:29 UTC) #11
reed1
lgtm
4 years, 3 months ago (2016-09-01 14:46:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296843002/20001
4 years, 3 months ago (2016-09-01 15:24:26 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 15:52:33 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4bb029cd9f7c00ac146df1f4c66d1ac5c078b78b

Powered by Google App Engine
This is Rietveld 408576698