Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: mojo/public/cpp/bindings/lib/message_header_validator.cc

Issue 229683005: Validate MessageHeader before using (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: apply fixes per review feedback Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/message_header_validator.cc
diff --git a/mojo/public/cpp/bindings/lib/message_header_validator.cc b/mojo/public/cpp/bindings/lib/message_header_validator.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9205ec5cef65c851bc82ed076d339039a98004d8
--- /dev/null
+++ b/mojo/public/cpp/bindings/lib/message_header_validator.cc
@@ -0,0 +1,73 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "mojo/public/cpp/bindings/lib/message_header_validator.h"
+
+#include "mojo/public/cpp/bindings/lib/bindings_serialization.h"
+
+namespace mojo {
+namespace internal {
+namespace {
+
+bool IsValidMessageHeader(const internal::MessageHeader* header) {
+ // Validate num_bytes:
+
+ if (header->num_bytes < sizeof(internal::MessageHeader))
+ return false;
+ if (internal::Align(header->num_bytes) != header->num_bytes)
+ return false;
+
+ // Validate num_fields:
+
+ if (header->num_fields < 2)
+ return false;
+ if (header->num_fields == 2) {
+ if (header->num_bytes != sizeof(internal::MessageHeader))
+ return false;
+ } else if (header->num_fields == 3) {
+ if (header->num_bytes != sizeof(internal::MessageHeaderWithRequestID))
+ return false;
+ } else if (header->num_fields > 3) {
+ if (header->num_bytes < sizeof(internal::MessageHeaderWithRequestID))
+ return false;
+ }
+
+ // Validate flags (allow unknown bits):
+
+ // These flags require a RequestID.
+ if (header->num_fields < 3 &&
+ ((header->flags & internal::kMessageExpectsResponse) ||
+ (header->flags & internal::kMessageIsResponse)))
+ return false;
+
+ // These flags are mutually exclusive.
+ if ((header->flags & internal::kMessageExpectsResponse) &&
+ (header->flags & internal::kMessageIsResponse))
+ return false;
+
+ return true;
+}
+
+} // namespace
+
+MessageHeaderValidator::MessageHeaderValidator(MessageReceiver* next)
+ : next_(next) {
+ assert(next);
+}
+
+bool MessageHeaderValidator::Accept(Message* message) {
+ if (!IsValidMessageHeader(message->header()))
+ return false; // Simulate an unhappy receiver.
+
+ return next_->Accept(message);
+}
+
+bool MessageHeaderValidator::AcceptWithResponder(Message* message,
+ MessageReceiver* responder) {
+ assert(false); // Not reached!
+ return false;
+}
+
+} // namespace internal
+} // namespace mojo

Powered by Google App Engine
This is Rietveld 408576698