mojo/public/cpp/bindings/lib/connector.cc - Issue 229683005: Validate MessageHeader before using

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/connector.cc

Issue 229683005: Validate MessageHeader before using (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove validation_interfaces.mojom for now Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/lib/connector.cc

diff --git a/mojo/public/cpp/bindings/lib/connector.cc b/mojo/public/cpp/bindings/lib/connector.cc

index 319631cbdf8cc8c0d281c2d3c9d8ed7ba4377e76..17f960442fee36f2ff31c9db129f0512babc4321 100644

--- a/mojo/public/cpp/bindings/lib/connector.cc

+++ b/mojo/public/cpp/bindings/lib/connector.cc

@@ -114,12 +114,14 @@ void Connector::ReadMore() {

while (true) {

MojoResult rv;

- rv = ReadAndDispatchMessage(message_pipe_.get(), incoming_receiver_, NULL);

+ bool receiver_result;

+ rv = ReadAndDispatchMessage(message_pipe_.get(), incoming_receiver_,

+ &receiver_result);

if (rv == MOJO_RESULT_SHOULD_WAIT) {

WaitToReadMore();

break;

}

- if (rv != MOJO_RESULT_OK) {

+ if (rv != MOJO_RESULT_OK || !receiver_result) {

error_ = true;

break;

}