Issue 229683004: Get rid of UpdateSubmoduleConfig.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 229683004: Get rid of UpdateSubmoduleConfig. (Closed)

Created:
6 years, 8 months ago by szager1

Modified:
6 years, 2 months ago

Reviewers:
hinoka, iannucci, jochen (gone - plz use gerrit), scottmg

CC:
chromium-reviews, cmp-cc_chromium.org, Dirk Pranke, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Get rid of UpdateSubmoduleConfig. It runs very slowly on Windows, and it will soon be obsolete. BUG= R=iannucci@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262770

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -35 lines)			Patch
	M	gclient_scm.py	View	1	5 chunks	+0 lines, -28 lines	1 comment	Download
	M	tests/gclient_scm_test.py	View	1	2 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

szager1

Committed patchset #2 manually as r262770 (presubmit successful).

6 years, 8 months ago (2014-04-09 19:27:27 UTC) #4

jochen (gone - plz use gerrit)

6 years, 2 months ago (2014-10-20 10:48:25 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/229683004/diff/20001/gclient_scm.py
File gclient_scm.py (left):

https://codereview.chromium.org/229683004/diff/20001/gclient_scm.py#oldcode282
gclient_scm.py:282: cmd3 = ['git', 'config', 'branch.autosetupmerge']
autosetupmerge wasn't really related to submodules, was it?

is it now setup somewhere else?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages