Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2296803002: GN: add sksl (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
ethannicholas
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M BUILD.gn View 1 4 chunks +11 lines, -2 lines 0 comments Download
M gyp/sksl.gypi View 1 chunk +12 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
mtklein_C
4 years, 3 months ago (2016-08-30 16:56:48 UTC) #7
ethannicholas
On 2016/08/30 16:56:48, mtklein_C wrote: lgtm
4 years, 3 months ago (2016-08-30 17:01:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296803002/20001
4 years, 3 months ago (2016-08-30 17:03:10 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 17:37:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9e0d9ddc0ef39e239670b22e5439993c45f4ae42

Powered by Google App Engine
This is Rietveld 408576698