ThreadWatcher: fix use-after-delete bug.

ThreadWatcher: fix use-after-delete bug.

When a StartupTimeBomb instance deletes itself, it may schedule a future
task to complete the deletion, and this future task must not reference
the destructed instance.

BUG=none
TEST=unit tests

Committed: https://crrev.com/22149529e840b4328b0004f7f1a4836605f67fc8
Cr-Commit-Position: refs/heads/master@{#415716}

[Joshua LeVasseur, 2016-08-30 20:03:58]

The CQ bit was checked by jlevasseur@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 20:04:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Joshua LeVasseur, 2016-08-30 20:12:51]

Description was changed from

==========
ThreadWatcher: fix use-after-delete bug.

When a StartupTimeBomb instance deletes itself, it may schedule a future
task to complete the deletion, and this future task must not reference
the destructed instance.

BUG=none
TEST=unit tests
==========

to

==========
ThreadWatcher: fix use-after-delete bug.

When a StartupTimeBomb instance deletes itself, it may schedule a future
task to complete the deletion, and this future task must not reference
the destructed instance.

BUG=none
TEST=unit tests
==========

[Joshua LeVasseur, 2016-08-30 20:12:52]

jlevasseur@chromium.org changed reviewers:
+ isherman@chromium.org, rtenneti@chromium.org, wzhong@chromium.org

[Joshua LeVasseur, 2016-08-30 20:15:41]

jlevasseur@chromium.org changed reviewers:
+ alokp@chromium.org

[commit-bot: I haz the power, 2016-08-30 21:03:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 21:03:59]

Dry run: This issue passed the CQ dry run.

[Joshua LeVasseur, 2016-08-30 21:21:47]

This is in preparation for turning ThreadWatcher into a component.

[ramant (doing other things), 2016-08-30 21:37:07]

LGTM. Thanks for fixing this. Please wait for llya and other's approval.

[wzhong, 2016-08-30 23:08:39]

lgtm

https://codereview.chromium.org/2296793003/diff/1/chrome/browser/metrics/thre...
File chrome/browser/metrics/thread_watcher.cc (right):

https://codereview.chromium.org/2296793003/diff/1/chrome/browser/metrics/thre...
chrome/browser/metrics/thread_watcher.cc:900: const base::PlatformThreadId
thread_id,
Nit: const is not needed.

[Ilya Sherman, 2016-08-30 23:44:06]

LGTM, thanks.

[Joshua LeVasseur, 2016-08-31 19:08:54]

The CQ bit was checked by jlevasseur@chromium.org

[commit-bot: I haz the power, 2016-08-31 19:09:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 19:14:46]

Description was changed from

==========
ThreadWatcher: fix use-after-delete bug.

When a StartupTimeBomb instance deletes itself, it may schedule a future
task to complete the deletion, and this future task must not reference
the destructed instance.

BUG=none
TEST=unit tests
==========

to

==========
ThreadWatcher: fix use-after-delete bug.

When a StartupTimeBomb instance deletes itself, it may schedule a future
task to complete the deletion, and this future task must not reference
the destructed instance.

BUG=none
TEST=unit tests
==========

[commit-bot: I haz the power, 2016-08-31 19:14:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-31 19:16:53]

Description was changed from

==========
ThreadWatcher: fix use-after-delete bug.

When a StartupTimeBomb instance deletes itself, it may schedule a future
task to complete the deletion, and this future task must not reference
the destructed instance.

BUG=none
TEST=unit tests
==========

to

==========
ThreadWatcher: fix use-after-delete bug.

When a StartupTimeBomb instance deletes itself, it may schedule a future
task to complete the deletion, and this future task must not reference
the destructed instance.

BUG=none
TEST=unit tests

Committed: https://crrev.com/22149529e840b4328b0004f7f1a4836605f67fc8
Cr-Commit-Position: refs/heads/master@{#415716}
==========

[commit-bot: I haz the power, 2016-08-31 19:16:54]

Patchset 1 (id:??) landed as
https://crrev.com/22149529e840b4328b0004f7f1a4836605f67fc8
Cr-Commit-Position: refs/heads/master@{#415716}