Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: PRESUBMIT_test.py

Issue 2296783002: Adds new logging type SYSLOG which logs to the system log. (Closed)
Patch Set: Moved the SYSLOG code to a separate file. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « PRESUBMIT.py ('k') | PRESUBMIT_test_mocks.py » ('j') | base/syslog_logging.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT_test.py
diff --git a/PRESUBMIT_test.py b/PRESUBMIT_test.py
index a8a3c27ab7f81790ccbcd083bbbf257e8c9430dd..7a30e29e2450c342f42f957c69a6e010c758da43 100755
--- a/PRESUBMIT_test.py
+++ b/PRESUBMIT_test.py
@@ -857,6 +857,10 @@ class PydepsNeedsUpdatingTest(unittest.TestCase):
checker_for_tests=self.checker)
def testAddedPydep(self):
+ # PRESUBMIT._CheckPydepsNeedsUpdating is only implemented for Android.
+ if self.mock_input_api.platform != 'linux2':
+ return []
+
self.mock_input_api.files = [
MockAffectedFile('new.pydeps', [], action='A'),
]
@@ -866,6 +870,10 @@ class PydepsNeedsUpdatingTest(unittest.TestCase):
self.assertTrue('PYDEPS_FILES' in str(results[0]))
def testRemovedPydep(self):
+ # PRESUBMIT._CheckPydepsNeedsUpdating is only implemented for Android.
+ if self.mock_input_api.platform != 'linux2':
+ return []
+
self.mock_input_api.files = [
MockAffectedFile(PRESUBMIT._ALL_PYDEPS_FILES[0], [], action='D'),
]
@@ -875,6 +883,10 @@ class PydepsNeedsUpdatingTest(unittest.TestCase):
self.assertTrue('PYDEPS_FILES' in str(results[0]))
def testRandomPyIgnored(self):
+ # PRESUBMIT._CheckPydepsNeedsUpdating is only implemented for Android.
+ if self.mock_input_api.platform != 'linux2':
+ return []
+
self.mock_input_api.files = [
MockAffectedFile('random.py', []),
]
@@ -883,6 +895,10 @@ class PydepsNeedsUpdatingTest(unittest.TestCase):
self.assertEqual(0, len(results), 'Unexpected results: %r' % results)
def testRelevantPyNoChange(self):
+ # PRESUBMIT._CheckPydepsNeedsUpdating is only implemented for Android.
+ if self.mock_input_api.platform != 'linux2':
+ return []
+
self.mock_input_api.files = [
MockAffectedFile('A.py', []),
]
@@ -897,6 +913,10 @@ class PydepsNeedsUpdatingTest(unittest.TestCase):
self.assertEqual(0, len(results), 'Unexpected results: %r' % results)
def testRelevantPyOneChange(self):
+ # PRESUBMIT._CheckPydepsNeedsUpdating is only implemented for Android.
+ if self.mock_input_api.platform != 'linux2':
+ return []
+
self.mock_input_api.files = [
MockAffectedFile('A.py', []),
]
@@ -912,6 +932,10 @@ class PydepsNeedsUpdatingTest(unittest.TestCase):
self.assertTrue('File is stale' in str(results[0]))
def testRelevantPyTwoChanges(self):
+ # PRESUBMIT._CheckPydepsNeedsUpdating is only implemented for Android.
+ if self.mock_input_api.platform != 'linux2':
+ return []
+
self.mock_input_api.files = [
MockAffectedFile('C.py', []),
]
« no previous file with comments | « PRESUBMIT.py ('k') | PRESUBMIT_test_mocks.py » ('j') | base/syslog_logging.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698