Issue 2296773002: Revert "Move error checking from scope creation to error reporter" (TBD)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2296773002: Revert "Move error checking from scope creation to error reporter" (TBD) (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson

Modified:
4 years, 3 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Move error checking from scope creation to error reporter" (TBD) Committed: https://github.com/dart-lang/sdk/commit/f7f1f40a94f7d68d705e9eb31cd5d1d40fb92600

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -222 lines)			Patch
M	pkg/analyzer/lib/src/dart/resolver/scope.dart	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/error_verifier.dart	View	8 chunks	+3 lines, -205 lines	0 comments	Download
M	pkg/analyzer/test/generated/compile_time_error_code_test.dart	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	pkg/analyzer/test/generated/non_error_resolver_test.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	2 chunks	+10 lines, -8 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_test.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

Committed patchset #1 (id:1) manually as f7f1f40a94f7d68d705e9eb31cd5d1d40fb92600 (presubmit successful).

4 years, 3 months ago (2016-08-30 15:00:59 UTC) #2

Message was sent while issue was closed.

lgtm