Issue 2296743002: Ignore the base/trace_event directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2296743002: Ignore the base/trace_event directory (Closed)

Created:
4 years, 3 months ago by dsinclair

Modified:
4 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	.gitignore	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296743002/1

4 years, 3 months ago (2016-08-30 14:17:08 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/50034a679249390852ac26a4119d35fbe124300e

4 years, 3 months ago (2016-08-30 14:41:44 UTC) #4

Lei Zhang

4 years, 3 months ago (2016-08-31 05:18:17 UTC) #6

Message was sent while issue was closed.

Though I suspect we should ignore just /base. It looks like everything V8 is
getting rebuilt on every bot run.